Security: reduce paths inspected on common OSes #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Should also address #11 by-the-by. |
cpu
approved these changes
Jan 23, 2025
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #2 and #4 are pretty esoteric and inappropriate for most users. This PR compiles them out based on
target_os.Most importantly, nothing really guarantees that
/datais a good place for look for anything on a common OS. In the security report we received yesterday againstrustls-native-certs(which uses this crate), it was theorized that a rust binary running in a minimal docker image that operates on untrusted input mounted into/datawould be tricked into trusting root certs included in the untrusted data. That is both surprising and very bad.The haiku case is marginal because
/bootis at least blessed in FHS. However I think this list of search paths should be minimal, since it is security-sensitive for much of the rust ecosystem.