From 01c8c930bf08eddb09d42c2b0a4db70e2bed491b Mon Sep 17 00:00:00 2001 From: Dirkjan Ochtman Date: Thu, 14 Mar 2024 09:55:20 +0100 Subject: [PATCH 1/3] Unbreak CRL doctests --- rcgen/src/crl.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rcgen/src/crl.rs b/rcgen/src/crl.rs index 8bafd693..700e69d7 100644 --- a/rcgen/src/crl.rs +++ b/rcgen/src/crl.rs @@ -40,7 +40,7 @@ use crate::{ /// let remote_key_pair = MyKeyPair { public_key: vec![] }; /// #[cfg(not(feature = "crypto"))] /// let key_pair = KeyPair::from_remote(Box::new(remote_key_pair)).unwrap(); -/// let issuer = Certificate::generate_self_signed(issuer_params, &key_pair).unwrap(); +/// let issuer = issuer_params.self_signed(&key_pair).unwrap(); /// // Describe a revoked certificate. /// let revoked_cert = RevokedCertParams{ /// serial_number: SerialNumber::from(9999), From f5084f6009e87618c53e36242b5c409c3fcf2160 Mon Sep 17 00:00:00 2001 From: Dirkjan Ochtman Date: Thu, 14 Mar 2024 09:55:37 +0100 Subject: [PATCH 2/3] Avoid --all-targets for cargo test in CI workflows --- .github/workflows/ci.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f0d17248..b9ab7aab 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -133,15 +133,15 @@ jobs: - name: Run cargo check run: cargo check --all-targets - name: Run the tests - run: cargo test --all-targets + run: cargo test - name: Run the tests with x509-parser enabled - run: cargo test --verbose --features x509-parser --all-targets + run: cargo test --verbose --features x509-parser - name: Run the tests with aws_lc_rs backend enabled - run: cargo test --verbose --no-default-features --features aws_lc_rs,pem --all-targets + run: cargo test --verbose --no-default-features --features aws_lc_rs,pem - name: Run the tests with FIPS aws_lc_rs module - run: cargo test --verbose --no-default-features --features fips,pem --all-targets + run: cargo test --verbose --no-default-features --features fips,pem - name: Run the tests with no features enabled - run: cargo test --verbose --no-default-features --all-targets + run: cargo test --verbose --no-default-features build: strategy: @@ -176,13 +176,13 @@ jobs: - name: Run cargo check run: cargo check --all-targets - name: Run the tests - run: cargo test --all-targets + run: cargo test - name: Run the tests with x509-parser enabled - run: cargo test --verbose --features x509-parser --all-targets + run: cargo test --verbose --features x509-parser - name: Run the tests with aws_lc_rs backend enabled - run: cargo test --verbose --no-default-features --features aws_lc_rs,pem --all-targets + run: cargo test --verbose --no-default-features --features aws_lc_rs,pem - name: Run the tests with FIPS aws_lc_rs module - run: cargo test --verbose --no-default-features --features fips,pem --all-targets + run: cargo test --verbose --no-default-features --features fips,pem # Build rustls-cert-gen as a standalone package, see this PR for why it's needed: # https://github.com/rustls/rcgen/pull/206#pullrequestreview-1816197358 From dce2afe41069f36242f02ffe7ffde1d639a257d6 Mon Sep 17 00:00:00 2001 From: Dirkjan Ochtman Date: Thu, 14 Mar 2024 09:56:08 +0100 Subject: [PATCH 3/3] Fix invalid reference in CI workflow --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b9ab7aab..5c65efc6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -66,7 +66,7 @@ jobs: - name: cargo doc (all features) run: cargo doc --all-features --document-private-items env: - RUSTDOCFLAGS: ${{ matrix.rust_channel == 'nightly' && '-Dwarnings --cfg=docsrs' || '-Dwarnings' }} + RUSTDOCFLAGS: ${{ matrix.toolchain == 'nightly' && '-Dwarnings --cfg=docsrs' || '-Dwarnings' }} check-external-types: name: Validate external types appearing in public API