-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: use a fixed SystemTime for certificate validation #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's two other items that should be fixed/acknowledged here as well:
- This comment block should be deleted because its no longer accurate.
- We should see if the OSCP stapling test can be uncommented finally. If it doesn't work right away or needs medium effort to revive it can be punted to a followup issue.
let me see if I can get it working. I think at a minimum we'll need to refresh the vendored OCSP resp. The one in-repo expired in 2021:
|
Oh, well the |
06f8735
to
6ed2f94
Compare
Fixing the `SystemTime` that we pass to the certificate verifier for the mock and real world verification tests will ensure that the tests don't start to fail just because the vendored certificates have expired.
* Fix the date the files were vendored * Fix the validity period * Fix the ref to the tool used to update them
6ed2f94
to
1c03c96
Compare
Fixed.
I started on this, but surprisingly the Windows verifier seems to be returning |
Conditionally adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on that followup issue quick!
Fixing the
SystemTime
that we pass to the certificate verifier for the real world and mock verification tests will ensure that the tests don't start to fail just because the vendored certificates have expired.Suggested by @complexspaces in #46