Don't add empty certificate_authorities extension
#1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 96.16% 96.16% -0.01%
==========================================
Files 80 80
Lines 17345 17342 -3
==========================================
- Hits 16680 16677 -3
Misses 665 665 ☔ View full report in Codecov by Sentry. |
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
|
If there is already a test case, how come it didn't fail? It must not be a good test case for this particular failure mode? |
djc
approved these changes
Jan 5, 2024
|
The existing test case is rustls/rustls/src/client/common.rs Lines 75 to 76 in b3913a5 With that said, I just took a second look, and:
|
|
Okay, nice. Why don't we support that in the bogo shim? Would it be hard to add support? |
This acts as a regression test for the previous commit. This also enables: - TLS12-Server-CertReq-CA-List - TLS13-Server-CertReq-CA-List - Null-Client-CA-List
ctz
force-pushed
the
jbp-omit-empty-certificate-authorities-extension
branch
from
c990b62
to
2dad93c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's already a test case for this and the API-level behaviour is unchanged.
fixes #1727