Expose ConfigBuilder::crypto_provider()#2181
Merged
Merged
Conversation
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
djc
force-pushed
the
config-builder-provider
branch
from
3c7ad04 to
40694f8
Compare
ctz
approved these changes
Oct 25, 2024
Member
Author
|
Does this need some test coverage? Where/how? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
==========================================
+ Coverage 94.72% 94.79% +0.07%
==========================================
Files 102 102
Lines 23753 24468 +715
==========================================
+ Hits 22499 23195 +696
- Misses 1254 1273 +19 ☔ View full report in Codecov by Sentry. |
Member
Author
|
I think this is semver-compatibility failure is probably not a big deal: (Especially since in practice, all instances of |
cpu
approved these changes
Oct 25, 2024
cpu
left a comment
cpu
left a comment
Member
There was a problem hiding this comment.
I trust your evaluation of the semver reporting 👍
Member
I think it wouldn't hurt & seems like an easy lift. Maybe update these two tests to save the |
djc
force-pushed
the
config-builder-provider
branch
from
40694f8 to
4bb9107
Compare
Member
Author
|
Added tests sort of like you suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables downstream projects (such as rustls-platform-verifier -- see rustls/rustls-platform-verifier#150) to get the
CryptoProviderfrom theConfigBuilder, instead of having to pick one in parallel.