Don't warn on UserCanceled alerts#2184
Merged
Merged
Conversation
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
cpu
approved these changes
Oct 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
==========================================
- Coverage 94.66% 94.65% -0.01%
==========================================
Files 102 102
Lines 23748 24031 +283
==========================================
+ Hits 22480 22746 +266
- Misses 1268 1285 +17 ☔ View full report in Codecov by Sentry. |
ctz
approved these changes
Oct 27, 2024
Member
ctz
left a comment
ctz
left a comment
There was a problem hiding this comment.
Maybe we could gate this warn! under debug_assertions instead? I don't think a warning alert is ever actionable in production, but it's nice to have it in logs for debugging purposes.
Maybe we could note https://bugs.openjdk.org/browse/JDK-8323517 and https://bugs.openjdk.org/browse/JDK-8282600 somewhere, because AIUI Java is the only implementation that sends user_canceled like it's going out of fashion (I believe NSS also sends it, but that is under user control and matches the purpose of the alert.)
Member
Author
|
Adapted as suggested by @ctz. |
ctz
approved these changes
Oct 28, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2182.