Skip to content

Improve Quality Control queries #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Improve Quality Control queries #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions db/qc/osm_tag_suggestions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

This should only be used as a guide for humans with further review and discussion in the process.
*/
DROP TABLE IF EXISTS osm_qc;
CREATE TEMP TABLE osm_qc AS
SELECT geom_type, osm_id,
'Update to: amenity=bicycle_parking per https://wiki.openstreetmap.org/wiki/Key:bicycle_parking'::TEXT
AS suggestion,
Expand Down Expand Up @@ -45,4 +47,30 @@ SELECT t.geom_type, t.osm_id,
t.osm_url, t.tags
FROM osm.tags t
WHERE t.tags->>'natural' = 'street_lamp'
UNION
SELECT t.geom_type, t.osm_id,
'Missing addr:street tag when record has addr:housenumber.'::TEXT
AS suggestion,
t.osm_url, t.tags
FROM osm.tags t
WHERE t.tags->>'addr:housenumber' IS NOT NULL
AND t.tags ->> 'addr:street' IS NULL
;


-- Show counts of each detected suggestion
SELECT suggestion, COUNT(*) AS cnt
FROM osm_qc
GROUP BY suggestion
ORDER BY cnt DESC
;


-- Explore data for specific suggestion
SELECT q.*, u.geom
FROM osm_qc q
INNER JOIN osm.unitable u
ON q.geom_type = u.geom_type
AND q.osm_id = u.osm_id
WHERE suggestion = 'Missing addr:street tag when record has addr:housenumber.'
;