Cleanup Cargo.lock files across workspace
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes stale `Cargo.lock` files leftover from when before all of the crates in this workspace were merged into a single repo. Also moves `platforms/markdown-table-gen` out of the toplevel workspace, and ignores lockfiles for both it and `platforms/platforms-data-gen`.
tarcieri
added a commit
that referenced
this pull request
Apr 23, 2022
The `version` field was previously being completely ignored. This commit first fixes the tests so they run locally again (they were broken in #533 but due to a quirk of how CI runs, namely nuking the toplevel workspace Cargo.toml to support a 1.40 MSRV, they continued to pass in CI). It removes all previous dependencies on `cargo-lock` having a Cargo.lock file (kind of silly to use something that changes as a test vector) and replaces it with explicit V2 and V3 lockfile test vectors, which are now in a newly renamed `tests/examples` directory. Finally, it fixes parsing of V3 lockfiles, actually paying attention to the `version` field if present.
tarcieri
added a commit
that referenced
this pull request
Apr 23, 2022
The `version` field was previously being completely ignored. This commit first fixes the tests so they run locally again (they were broken in #533 but due to a quirk of how CI runs, namely nuking the toplevel workspace Cargo.toml to support a 1.40 MSRV, they continued to pass in CI). It removes all previous dependencies on `cargo-lock` having a Cargo.lock file (kind of silly to use something that changes as a test vector) and replaces it with explicit V2 and V3 lockfile test vectors, which are now in a newly renamed `tests/examples` directory. Finally, it fixes parsing of V3 lockfiles, actually paying attention to the `version` field if present.
tarcieri
added a commit
that referenced
this pull request
Apr 23, 2022
The `version` field was previously being completely ignored. This commit first fixes the tests so they run locally again (they were broken in #533 but due to a quirk of how CI runs, namely nuking the toplevel workspace Cargo.toml to support a 1.40 MSRV, they continued to pass in CI). It removes all previous dependencies on `cargo-lock` having a Cargo.lock file (kind of silly to use something that changes as a test vector) and replaces it with explicit V2 and V3 lockfile test vectors, which are now in a newly renamed `tests/examples` directory. Finally, it fixes parsing of V3 lockfiles, actually paying attention to the `version` field if present.
tarcieri
added a commit
that referenced
this pull request
Apr 23, 2022
The `version` field was previously being completely ignored. This commit first fixes the tests so they run locally again (they were broken in #533 but due to a quirk of how CI runs, namely nuking the toplevel workspace Cargo.toml to support a 1.40 MSRV, they continued to pass in CI). It removes all previous dependencies on `cargo-lock` having a Cargo.lock file (kind of silly to use something that changes as a test vector) and replaces it with explicit V2 and V3 lockfile test vectors, which are now in a newly renamed `tests/examples` directory. Finally, it fixes parsing of V3 lockfiles, actually paying attention to the `version` field if present.
tarcieri
added a commit
that referenced
this pull request
Apr 23, 2022
The `version` field was previously being completely ignored. This commit first fixes the tests so they run locally again (they were broken in #533 but due to a quirk of how CI runs, namely nuking the toplevel workspace Cargo.toml to support a 1.40 MSRV, they continued to pass in CI). It removes all previous dependencies on `cargo-lock` having a Cargo.lock file (kind of silly to use something that changes as a test vector) and replaces it with explicit V2 and V3 lockfile test vectors, which are now in a newly renamed `tests/examples` directory. Finally, it fixes parsing of V3 lockfiles, actually paying attention to the `version` field if present.
cc: @tarcieri |
|
The intent of this PR was to remove the leftover crate-specific Cargo.lock files after combining the repo, now that all of the crates are in a workspace. A workspace shares a single Cargo.lock file. It seems a recent commit removed the toplevel Cargo.lock, however. Edit: aah, it was 8deceb7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes stale
Cargo.lockfiles leftover from when before all of the crates in this workspace were merged into a single repo.Also moves
platforms/markdown-table-genout of the toplevel workspace, and ignores lockfiles for both it andplatforms/platforms-data-gen.