New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features required by rusty-machine. #499

Open
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@sebcrozet
Copy link
Member

sebcrozet commented Dec 9, 2018

See #498.
This be work-in-progress as long as all the items from #498 are not checked.

@sebcrozet sebcrozet added this to the v0.17 milestone Dec 9, 2018

@jswrenn
Copy link
Member

jswrenn left a comment

It would be slightly more idiomatic to name these iterators Rows & RowsMut, and Cols and ColsMut.

Some examples of this pattern in the standard library include Chars and Values and ValuesMut.

@sebcrozet

This comment has been minimized.

Copy link
Member

sebcrozet commented Dec 9, 2018

@jswrenn I believe the convention is for the iterator type to have the same name as the method returning it. In our case the methods are row_iter(), row_iter_mut() etc, hence the RowIter, RowIterMut, etc names.

I didn't call those methods rows and rows_mut in the first place because those names are already used for slicing the matrix.

@jswrenn

This comment has been minimized.

Copy link
Member

jswrenn commented Dec 9, 2018

I forgot about those methods! You're right about the convention. The name conflict is unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment