New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-optimized builds on pure wasm backend #1

Closed
aturon opened this Issue Jan 10, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@aturon
Contributor

aturon commented Jan 10, 2018

Currently, compilation tends to go awry if you use wasm32-unknown-unknown without optimizations enabled. This is essentially due to immaturity of the rest of the toolchain; this issue is just for tracking the status.

@alexcrichton

This comment has been minimized.

Contributor

alexcrichton commented Jan 10, 2018

I believe at least one piece in solving this will be #3. If you leave LLVM assertions turned on then at lower optimization levels it often hits an LLVM assertion. There may also be bugs in binaryen's s2wasm right now, but I don't think we've ever gotten far enough to test that.

We shouldn't close this out automatically with #3 though because it's likely we'll need to do more than just upgrade llvm.

@alexcrichton

This comment has been minimized.

Contributor

alexcrichton commented Jan 28, 2018

Since upgrading to LLVM 6 this is unfortunately still not fixed, and I've started closing bugs in favor of rust-lang/rust#46367 which I plan to use as the rustc tracking issue for this.

@alexcrichton

This comment has been minimized.

Contributor

alexcrichton commented Jan 31, 2018

Initial testing shows that https://github.com/rust-lang-nursery/rust-wasm/issues/2 plus https://github.com/rust-lang-nursery/rust-wasm/issues/3 will solve this issue. Once those are in-tree though we should go through all the linked test cases on rust-lang/rust#46367 and make sure they work.

@alexcrichton

This comment has been minimized.

Contributor

alexcrichton commented Mar 4, 2018

With #2 and #3 now landed, I believe this works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment