Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm-pack tutorial paths #154

Closed
mgattozzi opened this issue Apr 19, 2018 · 4 comments
Closed

Update wasm-pack tutorial paths #154

mgattozzi opened this issue Apr 19, 2018 · 4 comments

Comments

@mgattozzi
Copy link
Contributor

We're just waiting for a 0.2 release of wasm-pack right now for this issue. In https://github.com/rust-lang-nursery/rust-wasm/pull/151 we changed a path reference from ./node_modules/@MYSCOPE/wasm-add/wasm_add.js to @MYSCOPE/wasm-add/wasm_add.js. As was noted in #151 after https://github.com/ashleygwilliams/wasm-pack/issues/94 is closed we can shorten this further to @MYSCOPE/wasm-add which is more idiomatic for JS.

Mentoring instructions:

  1. In src/wasm-pack/run-the-code.md change the import statement of index.js to the above statement.
  2. Test that the changes work as part of the tutorial with the new syntax
@adityac8
Copy link
Contributor

adityac8 commented May 8, 2018

Hey, @mgattozzi I have gone through ashleygwilliams/wasm-pack and found that 0.2 was released. I suggest that we remove the blocked label. 😃

@mgattozzi mgattozzi removed the blocked label May 8, 2018
@mgattozzi
Copy link
Contributor Author

Hey @adityac8 thanks for reminding me. This should be good to go now :D

@adityac8
Copy link
Contributor

adityac8 commented May 9, 2018

I'm on it! 😸

@jrichocean
Copy link

This issue has been moved here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants