Don't use "./node_modules/" in the import path #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using webpack, modules from dependencies are usually not included through their actual paths on the file system. Instead, the include path starts with the name of the module and it's webpack's job to find the correct directory.
sendilkumarn
approved these changes
Apr 19, 2018
|
Hey @mstange just want to make sure, does this run correctly with wasm-pack right now? My understanding is we'll need to land a fix to close https://github.com/ashleygwilliams/wasm-pack/issues/94 first and release a version 0.2.0 |
|
I've tested this locally and it works correctly. This change is only changing it to |
|
Ok excellent just wanted to confirm. Let's get this merged. Thanks for the fix @mstange |
|
🎉 yay thank u! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using webpack, modules from dependencies are usually not included through their actual paths on the file system. Instead, the include path starts with the name of the module and it's webpack's job to find the correct directory.
On the other hand, having the full path here is nice because it tells the reader where to go looking for the actual files that wasm-pack produced. So I'm not sure if this is a good change.