Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wasmparser + support emitting multiple memories MemArgs #206

merged 4 commits into from Mar 31, 2021


Copy link

@bnjbvr bnjbvr commented Mar 31, 2021

The first commit bumps wasmparser. I've made the minimal changes so that it compiles and runs, but most of the new SIMD / exception handling stuff is left to be implemented later.

The second commit allows emitting MemArgs that deals with memories that aren't the primary (0th) memory, by setting the right flag. I've confirmed it works as expected when playing with it in Wasmtime.

Closes #205.

This adds support for re-emitting wasm code that interacts with multiple
memories, that is, not the primary (0th) one. Parsing support was
already present for reading MemArgs that referred to other memories.
@bnjbvr bnjbvr force-pushed the bump-wasmparser branch 2 times, most recently from 50af609 to 94389b0 Compare March 31, 2021 13:42
- Also update spec-tests and wabt to support newer features.
- Make it fuzz-safe when features aren't supported.
Copy link

Thanks for this!

@alexcrichton alexcrichton merged commit 990fa4c into rustwasm:master Mar 31, 2021
@bnjbvr bnjbvr deleted the bump-wasmparser branch March 31, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants