Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_truthy, is_falsy #1638

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Add is_truthy, is_falsy #1638

merged 3 commits into from
Aug 8, 2019

Conversation

ThomasdenH
Copy link
Contributor

@ThomasdenH ThomasdenH commented Jul 2, 2019 •
edited
Loading

This PR closes #1632.

I'd like to add tested examples to the documentation, but I'm not sure if that's possible with wasm_bindgen_test.

Pauan
Pauan suggested changes Jul 2, 2019
View reviewed changes
crates/cli-support/src/intrinsic.rs Outdated Show resolved Hide resolved
Pauan
Pauan approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@alexcrichton
Copy link
Contributor

Thanks! I think to include the tests though you'll need to add mod truthy_falsy to tests/wasm/main.rs

@ThomasdenH
Copy link
Contributor Author

I have added your suggestion. I don't know why the tests are failing.

@alexcrichton alexcrichton merged commit 67e858e into rustwasm:master Aug 8, 2019
@alexcrichton
Copy link
Contributor

Looks great! 👍

@ThomasdenH ThomasdenH mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pauan Pauan Pauan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add is_truthy and is_falsy
3 participants
@ThomasdenH @alexcrichton @Pauan