Skip to content

/wasm-bindgen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm interface types and multi-value #1805

Merged
merged 2 commits into from Oct 18, 2019
Merged

Wasm interface types and multi-value #1805

merged 2 commits into from Oct 18, 2019

Conversation

@fitzgen
Copy link
Member

fitzgen commented Oct 3, 2019

Depends on
fitzgen added 2 commits Oct 3, 2019
@fitzgen
Wasm interface types should imply multi-value
311ae19
@fitzgen
Get rid of the wasm interface types return pointer hacks
Loading status checks…
25dd84c 
Now that using standard Wasm interface types implies multi-value support, we
don't need these return pointer hacks anymore.
@fitzgen fitzgen requested a review from alexcrichton Oct 3, 2019
@alexcrichton
alexcrichton approved these changes Oct 4, 2019
View changes
Copy link
Collaborator

alexcrichton left a comment

Such a satisfying review on this one!
@fitzgen fitzgen merged commit fe4dd0b into rustwasm:master Oct 18, 2019
20 checks passed
20 checks passed
rustwasm.wasm-bindgen Build #20191003.7 succeeded
Details
rustwasm.wasm-bindgen (Build almost all examples) Build almost all examples succeeded
Details
rustwasm.wasm-bindgen (Build benchmarks) Build benchmarks succeeded
Details
rustwasm.wasm-bindgen (Build raytrace examples) Build raytrace examples succeeded
Details
rustwasm.wasm-bindgen (Deploy everything) Deploy everything succeeded
Details
rustwasm.wasm-bindgen (Dist Darwin binary) Dist Darwin binary succeeded
Details
rustwasm.wasm-bindgen (Dist Linux binary) Dist Linux binary succeeded
Details
rustwasm.wasm-bindgen (Dist Windows binary) Dist Windows binary succeeded
Details
rustwasm.wasm-bindgen (Doc - build the API documentation) Doc - build the API documentation succeeded
Details
rustwasm.wasm-bindgen (Doc - build the book) Doc - build the book succeeded
Details
rustwasm.wasm-bindgen (Run UI tests) Run UI tests succeeded
Details
rustwasm.wasm-bindgen (Run js-sys crate tests) Run js-sys crate tests succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen crate tests (Windows)) Run wasm-bindgen crate tests (Windows) succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen crate tests (nightly)) Run wasm-bindgen crate tests (nightly) succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen crate tests (unix)) Run wasm-bindgen crate tests (unix) succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen-cli crate tests) Run wasm-bindgen-cli crate tests succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen-wasm-interpreter tests) Run wasm-bindgen-wasm-interpreter tests succeeded
Details
rustwasm.wasm-bindgen (Run wasm-bindgen-webidl crate tests) Run wasm-bindgen-webidl crate tests succeeded
Details
rustwasm.wasm-bindgen (Run web-sys crate tests) Run web-sys crate tests succeeded
Details
rustwasm.wasm-bindgen (Test TypeScript output of wasm-bindgen) Test TypeScript output of wasm-bindgen succeeded
Details
@fitzgen fitzgen deleted the fitzgen:wasm-interface-types-and-multi-value branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fitzgen @alexcrichton
You can’t perform that action at this time.