Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upResult-ify `src/parser.rs` #608
Conversation
alexcrichton
added some commits
Aug 1, 2018
fitzgen
approved these changes
Aug 1, 2018
|
How does one run the UI tests? Is it the same as all of our other tests? If not, we should also document that. Also, are rustc error messages stable enough that we can rely on this stderr content remaining the same? Overall, this is a huge improvement for the UX of using wasm-bindgen! Thanks, Alex! |
This comment has been minimized.
This comment has been minimized.
We've got some handy documentation about that!
Indeed! A simple
I believe that since all this output is our error messages it should hopefully be pretty stable. That being said I wouldn't be surprised if these tests break over time. I'd like to eventually add UI tests as well for failing conditions like "you specified an argument that didn't implement I think we may eventually move this test suite into an "allow failures" category on Travis and only update it every now and then (such as when the test suite itself is modified), but for now we hopefully won't have too many issues! |
alexcrichton commentedAug 1, 2018
•
edited
This commit converts all of
src/parser.rsaway from panics to usingDiagnosticinstead. Along the way this adds a test case per changedpanic!,ensuring that we don't regress in these areas!
cc #601