Remove --wasm2asm flag, use binaryen directly #787
Conversation
Binaryen renamed the tool to wasm2js instead of wasm2asm - WebAssembly/binaryen#1642
The failing job is |
Thanks for the PR! I think though that |
It's working fine, I just wanted to update things since this blog post recommended use of |
Ah ok, great! If we want to keep the |
Not totally sure what you mean - are you referring to keeping the |
Well I'm not entirely sure. It sounds like you want to keep the If so, then this implemention is incorrect because it will wrap ES imports twice, once by Deleting |
Ah, that makes more sense. I'm actually mostly in favor of deleting the flag; if it's just a shim around |
Sounds good to me! |
Thanks! |
See rustwasm/wasm-bindgen#787 for more details. Thanks @bspeice for the notice!
Binaryen renamed the tool to wasm2js instead of wasm2asm - WebAssembly/binaryen#1642