Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug flag not passed to wasm-bindgen-cli #677

Closed
ashleygwilliams opened this issue Jul 16, 2019 · 6 comments · Fixed by #683
Closed

debug flag not passed to wasm-bindgen-cli #677

ashleygwilliams opened this issue Jul 16, 2019 · 6 comments · Fixed by #683
Labels
current release current todo items needs investigation to-do stuff that needs to happen, so plz do it k thx
Milestone
0.9.0

Comments

@ashleygwilliams
Copy link
Member 

failures:

---- build::build_with_and_without_wasm_bindgen_debug stdout ----
Created fixture at /Users/ag_dubs/OpenSource/rustwasm/wasm-pack/target/t/.tmpdZ5X82/wasm-pack
thread 'build::build_with_and_without_wasm_bindgen_debug' panicked at 'assertion failed: `(left == right)`
  left: `false`,
 right: `true`: Should only contain moved value assertions when debug assertions are enabled', tests/all/build.rs:195:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
@ashleygwilliams
Copy link
Member Author

any thoughts @fitzgen or @alexcrichton ?

@ashleygwilliams
Copy link
Member Author

getting these on master now too https://travis-ci.com/rustwasm/wasm-pack/jobs/216579394#L538

@ashleygwilliams ashleygwilliams added bug Something isn't working needs investigation labels Jul 16, 2019
@ashleygwilliams ashleygwilliams changed the title failing test on master re debug debug assertions test failing on master Jul 16, 2019
@ashleygwilliams
Copy link
Member Author

per in chat convo with @fitzgen- looks like we are testing on the contents of the error message.. which may have changed https://github.com/rustwasm/wasm-pack/blob/master/tests/all/build.rs#L197 i'll run it manually and see.

@fitzgen
Copy link
Member

fitzgen commented Jul 16, 2019

I don't see any difference between the JS glue when build with debug-js-glue = true or debug-js-glue = false.

@ashleygwilliams ashleygwilliams changed the title debug assertions test failing on master debug flag not passed to wasm-bindgen-cli Jul 16, 2019
@ashleygwilliams ashleygwilliams added current release current todo items to-do stuff that needs to happen, so plz do it k thx and removed bug Something isn't working labels Jul 16, 2019
@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Jul 16, 2019
@fitzgen
Copy link
Member

fitzgen commented Jul 16, 2019

I verified via strace that wasm-pack is not invoking wasm-bindgen with the --debug flag regardless whether debug-js-glue is set or not. Furthermore, if I manually invoke wasm-bindgen with --debug then the move assertion does appear in the JS glue.

@fitzgen
Copy link
Member

fitzgen commented Jul 16, 2019

False alert: I was building with the release profile and the test/configuration was for the dev profile.

wasm-pack is passing --debug to wasm-bindgen but wasm-bindgen is no longer emitting the assertion.

fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Jul 16, 2019
@fitzgen
test: Ensure that wasm-bindgen will generate move assertions
aa22396 
`wasm-bindgen` regressed and only generates move assertions for free functions,
not methods. While `wasm-bindgen` is fixing that regression, we are changing
this test fixture to be of the shape that will still generate move assertions.

Fixes rustwasm#677.
This was referenced Jul 16, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
current release current todo items needs investigation to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

test: Ensure that wasm-bindgen will generate move assertions fitzgen/wasm-pack
2 participants
@fitzgen @ashleygwilliams