New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New region detection mechanism breaks non-Amazon hosts #29

Closed
bdeutsch-heise opened this Issue Jul 10, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@bdeutsch-heise

bdeutsch-heise commented Jul 10, 2018

The recent version 0.82 with pull request #27 unfortunately breaks this module for non-Amazon S3 hosts (RADOS et al) with an error like the following:

Attribute (region) does not pass the type constraint because: Validation failed for 'Str' with value undef at reader Net::Amazon::S3::HTTPRequest::region

Before 0.82, the region happened to default to a defined bucket, but the current code returns undef if the header is missing.

Would it be possible to add a fallback value, like none, if the header is missing, or to relax the requirements on bucket regions?

branislav-zahradnik-gdc added a commit to branislav-zahradnik-gdc/net-amazon-s3 that referenced this issue Jul 10, 2018

branislav-zahradnik-gdc added a commit to branislav-zahradnik-gdc/net-amazon-s3 that referenced this issue Jul 10, 2018

@branislav-zahradnik-gdc

This comment has been minimized.

branislav-zahradnik-gdc commented Jul 10, 2018

bucket region is evaluated only in case of Signature 4.
Changing default authorization method so it will be Signature 4 only for amazonaws host.

branislav-zahradnik-gdc added a commit to branislav-zahradnik-gdc/net-amazon-s3 that referenced this issue Jul 10, 2018

@ranguard

This comment has been minimized.

Collaborator

ranguard commented Jul 10, 2018

@branislav-zahradnik-gdc I didn't see that commit in the PR I merged... guessing on the way :) - I'll hold off on a release for now :)

branislav-zahradnik-gdc added a commit to branislav-zahradnik-gdc/net-amazon-s3 that referenced this issue Jul 10, 2018

@ranguard

This comment has been minimized.

Collaborator

ranguard commented Jul 10, 2018

https://metacpan.org/release/LLAP/Net-Amazon-S3-0.83 - please comment if this does not fix it

@ranguard ranguard closed this Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment