New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run 'use_ok' on all modules #36

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@yanick

yanick commented Aug 22, 2018

tweaked the test to use_ok all the modules of the distro.

(done as part of the cpan PR challenge)

@branislav-zahradnik-gdc

This comment has been minimized.

Show comment
Hide comment
@branislav-zahradnik-gdc

branislav-zahradnik-gdc Aug 22, 2018

good idea, anyway, if you want to test just load modules, please use just require:

all_ok (suffix => ..., require => 1)

shuffle option will also help

please retain tests 1 + 1, it should signal that there are two kinds of tests (in this case one hidden in Test::Warnings

branislav-zahradnik-gdc commented Aug 22, 2018

good idea, anyway, if you want to test just load modules, please use just require:

all_ok (suffix => ..., require => 1)

shuffle option will also help

please retain tests 1 + 1, it should signal that there are two kinds of tests (in this case one hidden in Test::Warnings

@yanick

This comment has been minimized.

Show comment
Hide comment
@yanick

yanick Aug 22, 2018

I added back the 1+1 test plan. I looked at the code of Test::LoadAllModules, however, and it doesn't seem to support a require argument. Nor does it shuffle (which I'm not sure of, non-deterministic test runs are hiffy...).

yanick commented Aug 22, 2018

I added back the 1+1 test plan. I looked at the code of Test::LoadAllModules, however, and it doesn't seem to support a require argument. Nor does it shuffle (which I'm not sure of, non-deterministic test runs are hiffy...).

@branislav-zahradnik-gdc

This comment has been minimized.

Show comment
Hide comment
@branislav-zahradnik-gdc

branislav-zahradnik-gdc Aug 22, 2018

oh, you are right, sorry, my fault, I was looking at Test::AllModules :-)

branislav-zahradnik-gdc commented Aug 22, 2018

oh, you are right, sorry, my fault, I was looking at Test::AllModules :-)

@yanick

This comment has been minimized.

Show comment
Hide comment
@yanick

yanick Aug 22, 2018

Heh, that explains that. :-)

yanick commented Aug 22, 2018

Heh, that explains that. :-)

@branislav-zahradnik-gdc

This comment has been minimized.

Show comment
Hide comment
@branislav-zahradnik-gdc

branislav-zahradnik-gdc Aug 22, 2018

thanks for an idea.
can you please also squash ?

branislav-zahradnik-gdc commented Aug 22, 2018

thanks for an idea.
can you please also squash ?

@yanick

This comment has been minimized.

Show comment
Hide comment
@yanick

yanick Aug 22, 2018

Sure!

...

done.

yanick commented Aug 22, 2018

Sure!

...

done.

@ranguard ranguard merged commit 348f731 into rustyconover:master Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment