New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cpants issues #7

Merged
merged 2 commits into from Feb 21, 2018

Conversation

Projects
None yet
2 participants
@kyzn
Contributor

kyzn commented Feb 20, 2018

Hi! Thanks for maintaining this module.

This adds two things to PR #6:

  • Readme.md file
  • Minimum perl version (5.10) to both META files

Let me know if you want me to update anything. Thanks!

#cpan-prc

@ruz ruz merged commit 8cb7881 into ruz:master Feb 21, 2018

@ruz

This comment has been minimized.

Owner

ruz commented Feb 21, 2018

Thank you. Merged it in. However, required perl version should be defined in Build.PL as META files are regenerated while running ./Build dist. Also, I moved docs into POD of the primary .pm file and generated README from it using pod2markdown lib/Alien/LibGumbo.pm > README.md.

@kyzn

This comment has been minimized.

Contributor

kyzn commented Feb 22, 2018

You are right! Thanks for fixing it. Looks much better now! 🙂

@kyzn kyzn deleted the kyzn:kivanc/kwalitee branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment