New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make running the samples part of the test procedure #7

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tynovsky

tynovsky commented Dec 25, 2015

I've added a test which runs all the example scripts from samples directory. I've made only minimal adjustments to them to make it work. Please let me know if I can improve anything.

BTW, this PR is part of CPAN Pull Request Challenge. :-)

@ruz

This comment has been minimized.

Show comment
Hide comment
@ruz

ruz Dec 27, 2015

Owner

Can't we just assume that tests are run from the root of the repo, so we don't need FindBin?

Owner

ruz commented Dec 27, 2015

Can't we just assume that tests are run from the root of the repo, so we don't need FindBin?

@ruz

This comment has been minimized.

Show comment
Hide comment
@ruz

ruz Dec 27, 2015

Owner

merged manually with a tiny change

Owner

ruz commented Dec 27, 2015

merged manually with a tiny change

@ruz ruz closed this Dec 27, 2015

@ruz

This comment has been minimized.

Show comment
Hide comment
@ruz

ruz Dec 27, 2015

Owner

thank you

Owner

ruz commented Dec 27, 2015

thank you

@tynovsky

This comment has been minimized.

Show comment
Hide comment
@tynovsky

tynovsky Dec 27, 2015

Thanks for merge!

tynovsky commented Dec 27, 2015

Thanks for merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment