New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readable-stream@3 #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readable-stream drops support for Node 4 and 5 (and anything before that). Also, you might want to remove the custom destroy logic, as it’s already there. |
If Node.js 4 and 5 support is dropped, we can also remove the |
+1 to remove safe-buffer |
@mcollina anything i can do to move this along ? |
hugomrdias
approved these changes
Feb 27, 2019
lgtm, I guess this is semver-major, @mcollina do you want to cut a release? |
Yes it is!
Il giorno gio 28 feb 2019 alle 06:06 Rod Vagg <notifications@github.com> ha
scritto:
… lgtm, I guess this is semver-major, @mcollina
<https://github.com/mcollina> do you want to cut a release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#57 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AADL42mToGQ7cz6nESRRAp1savk2df5jks5vR2PBgaJpZM4V8KA->
.
|
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.