Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use const or let, enforce in linter #62

merged 2 commits into from Oct 12, 2018


Copy link

Hi Folks,

I hope I've understood everything right, but I'm hitting an issue on my build of autobahn which uses msgpack5 which uses bl, the recent PR #59 that was released includes the use of let and const. Since my build process does not transpile node_modules (which I've come to understand is typical) I suspected the appropriate fix was to use ES3 syntax instead.

If that is correct, then this PR should do just that by removing the usages of let and const and enforcing that in the jshint configuration.

If that is not correct, please excuse the mistake and if you have advice on how to fix my issue I'd greatly appreciate it.

Copy link

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@mcollina mcollina merged commit 91cbaf9 into rvagg:master Oct 12, 2018
Copy link

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants