`this.sliding` is always true in Chrome after first slide transition #4

Open
adamnbowen opened this Issue Jun 19, 2012 · 11 comments

2 participants

@adamnbowen

I'm in the middle of tracking this down, but it seems that this.sliding is always true in Chrome after the first transition.

You can see an example of this on my carousel.

The active class also doesn't seem to get removed/added to the appropriate slides, so the problem may be slightly deeper than just this.sliding.

If you have any ideas as to what might be the issue, I'd be glad for any help, otherwise, I'll be poking around a bit to see if I can correct the issue.

@rvagg
Owner

Off the top of my head, without looking at source, the only thought I have is that in 2.0.3 release I made the .to() function work, see #3. I can't recall exactly what I did other than introduce the $().index() method work but I do recall messing a bit with carousel to get it working. Perhaps you could try 2.0.2 and see if it's any different?
I'll pitch in to get help get this sorted when I have a free moment. Thanks for putting in the time on it!

@adamnbowen

No dice on v2.0.2---things fail pretty quickly in the Carousel plugin: it seems that $.browser is undefined, so the $.browser.webkit check on line 37 of transition.js fails pretty quickly. So at least v2.0.3 runs once, which is of course slightly better than not running at all ;)

@rvagg
Owner
@adamnbowen

Yeah, Bowser found its way in there (yay for ender build). I'll give the 1.0-wip branch a try tomorrow.

@rvagg
Owner

I'm just having a look at this now but it seems to be working for me OK, both the sliding property and the class (watching the DOM you can see it turn on and off) using the latest version which is 2.0.3-1. Can you see what versions of the other libs you have in your build? This is what I'm using in the version I'm playing with: ender-js@0.4.3-dev domready@0.2.11 bowser@0.2.0 qwery@3.3.6 bean@0.4.11-1 bonzo@1.0.6
'ender info` might help you out on this. The new version (1.0-wip) includes these details at the top of your build file for easy reference.

@rvagg
Owner

And.. just quickly looking at your script, it could be to do with the ordering of the packages in the build file. I see Bowser lower than it should be, it should be before the 'ender-bootstrap-base' package. Install ender@dev and rebuild and the order will at least be fixed.

@adamnbowen

hrm, when I try 1.0-wip ender, I'm now getting some Uncaught RangeError: Maximum call stack size exceeded from faker.extend---Don't know what happens in Firefox exactly, as it crashes Firebug ;).

I'll poke the stack a bit more, and maybe see if I can get myself a reduced use-case in working order (not that I have extensive JS on this site in the first place, but minimizing the problem is always good ;)

@adamnbowen

Hrm, I do have it working on my local machine with my minimum complexity case (just the bootstrap css, an index.html and ender.js built by ender build ender-bootstrap-carousel qwery). I guess I just need to build it up to the point where it either starts to fail, or magically fixes my site. I'll post back if I find out what the heck was going on ;)

@rvagg
Owner
@adamnbowen

Yeah, I thought about that (didn't know qwery wasn't included in the dependencies, so I added it afterward with ender add qwery), but I just figured I'd post exactly what I had.

@rvagg
Owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment