Permalink
Commits on Feb 19, 2013
  1. PHP5.4

    Richard van Velzen committed Feb 19, 2013
Commits on Dec 25, 2011
  1. Added (new stuff)->call() to the syntax

    Richard van Velzen committed Dec 25, 2011
  2. Merge branch 'master' of github:rvanvelzen/xhp

    Richard van Velzen committed Dec 25, 2011
  3. Empty $$ when lexical vars do not exist.

    Richard van Velzen committed Dec 25, 2011
  4. Empty $$ when lexical vars do not exist.

    Richard van Velzen committed Dec 25, 2011
Commits on Dec 24, 2011
  1. And now the code itself

    Richard van Velzen committed Dec 24, 2011
  2. Additions to make XHP suited for PHP5.4

    Richard van Velzen committed Dec 24, 2011
Commits on Sep 20, 2011
  1. Merge github.com:facebook/xhp

    Richard van Velzen committed Sep 20, 2011
Commits on Sep 12, 2011
  1. zend_error_noreturn() causes problems on new gcc

    Summary:
    Fix build error
    
    Test Plan:
    
    Reviewers:
    
    CC:
    scottmac committed Sep 12, 2011
Commits on Aug 8, 2011
  1. Fix static building of libxhp

    Description:
    libxhp didn't have the correct variable set in the include file.
    
    Also didn't include the path wherer to link libxhp from when it was static.
    scottmac committed Aug 8, 2011
Commits on Jul 2, 2011
  1. Added simple support for JSON-style arrays

    Richard van Velzen committed Jul 2, 2011
Commits on Jun 29, 2011
  1. The HTML() functionality is back

    Richard van Velzen committed Jun 29, 2011
  2. Show INI entries for XHP

    Richard van Velzen committed Jun 29, 2011
  3. Added support for unquoted numeric attribute values

    Richard van Velzen committed Jun 29, 2011
  4. Added support for unquoted numeric attribute values

    Richard van Velzen committed Jun 29, 2011
Commits on Jun 28, 2011
  1. Fix for issue #25 on facebook's repo

    Richard van Velzen committed Jun 28, 2011
  2. Deleted old README

    Richard van Velzen committed Jun 28, 2011
  3. Updated README (meh)

    Richard van Velzen committed Jun 28, 2011
  4. Added README

    Richard van Velzen committed Jun 28, 2011
  5. Added option for optional attribute values

    Richard van Velzen committed Jun 28, 2011
  6. Merge branch 'master' of github.com:rvanvelzen/xhp

    Richard van Velzen committed Jun 28, 2011
  7. Added the html addition

    Richard van Velzen committed Jun 28, 2011
  8. Test for attributes without values and a small addition to rendering …

    …boolean attributes.
    Richard van Velzen committed Jun 28, 2011
  9. Test for attributes without values and a small addition to rendering …

    …boolean attributes.
    Richard van Velzen committed Jun 28, 2011
Commits on Dec 2, 2010
  1. Update fastpath to catch opening tags.

    Summary:
    If you have something like:
    
      $foo = <div>Her's</div>;
    
    The fastpath won't pick up the XHP because it thinks it's inside of a string, and it only looks for closing tags, not opening tags. I added an expression to detect opening tags as well, which in practice won't have many false positives.
    
    Test Plan:
    New unit test. Also ran xhpize on FB sources and no new fastpath false positives were introduced.
    
    Reviewed By: epriestley
    laverdet committed Dec 2, 2010
Commits on Jul 14, 2010
  1. Add a few comments in the XHP lexer

    Summary:
    While porting the XHP grammar to pfff I've made a few comments
    on the code that could be useful for other.
    
    Test Plan:
    cd xhp; make; ./xhpize -d ../tests/attr-blank.php
    seems to work.
    
    I was not able to make tests :(
    I get some:
    PHP Warning:  PHP Startup: Unable to load dynamic library 'modules/fb.so' -
    modules/fb.so: cannot open shared object file: No such file or directory in
    Unknown on line 0
    ...
    Running selected tests.
    FAIL Constant in Array [tests/array-constant.phpt]
    FAIL Blank attribute [tests/attr-blank.phpt]
    
    DiffCamp Revision: 132409
    Reviewed By: marcel
    CC: marcel
    Revert Plan:
    OK
    pad committed Jul 14, 2010
Commits on Jun 25, 2010
  1. Fix parser glitch with <script />

    Summary:
    You can open and close PHP blocks with <script> and </script> which my fastpath parser tries to take into account. But the XHP detection looks for closing tags for its primary detection, so when it sees the closing </script> it leaves PHP context and then doesn't detect any XHP. I'm removing the closing </script> context switch which will slow down the fastpath in some stupid cases when people use <script language="php"> but whatever, no one does that. False positives are acceptable, false negatives are not.
    
    Test Plan:
    Unit test.
    
    Reviewed By: epriestley
    laverdet committed Jun 25, 2010
Commits on May 28, 2010
  1. Fix invalid line numbers on syntax error

    Summary:
    If you encounter a syntax error via a mismatched tag, the line number it gives you may be messed up. This is because we only mark the parser as terminated but let it continue its work. This keeps eating up tokens and advancing the line number. So now we don't let the scanner continue if the parser has been marked as terminated, thus the line number remains where it was when we found the error.
    
    Test Plan:
    Unit tests.
    
    Reviewed By: kdelong
    laverdet committed May 28, 2010
Commits on May 17, 2010
  1. Make categories not replace -, : etc

    Summary:
    Categories just become array keys so there's no need to replace them like we do identifiers.
    
    Test Plan:
    rebuild & reload
    
    Reviewed By: kdelong
    laverdet committed May 17, 2010
  2. Stricter whitespace rules

    Summary:
    Basically this diff makes is so that XHP whitespace behaves as I said it would from the start. Pure whitespace in between nodes is truncated, leading and trailing whitespace between a text node and something else is collapsed into a space.
    
    Test Plan:
    Unit tests
    
    Reviewed By: kdelong
    laverdet committed May 14, 2010
Commits on May 12, 2010
  1. Cleaning up the XHP bug list

    Summary:
    - Allow XHP constants in arrays, i.e. array('foo' => :foo::bar);
    - Fix handling of ?> and </script> in heredoc
    http://github.com/facebook/xhp/issues/issue/11
    - Fix 2 bugs with line numbers getting corrupted
    - Fix use of "xor", "or", and "and" operators
    http://github.com/facebook/xhp/issues/issue/12
    - Whitespace issues (need more tests)
    
    Test Plan:
    Added unit tests for each bug fixed. All tests passed successfully.
    
    Reviewed By: martin
    laverdet committed May 12, 2010
Commits on Mar 9, 2010
  1. Adding float attribute type to XHP.

    Summary:
    Add a new type for attributes in XHP for float (AKA double).
    
    Reviewed By: marcel
    
    Test Plan:
    Added a new test for float attributes.
    Nora Mullaney committed Mar 8, 2010