-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update common interface #19
Conversation
I'm not sure what that load path stuff was in the tests, but that was required to be removed for tests to pass, and definitely would be required on CI. |
Changes Unknown when pulling a85fa99 on update_ into ** on master**. |
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage ? 87.04%
=========================================
Files ? 4
Lines ? 193
Branches ? 0
=========================================
Hits ? 168
Misses ? 25
Partials ? 0
Continue to review full report at Codecov.
|
Cool. Tests pass. Would you be fine with a release after merging? I think there may be a nonlocality bug in the package resolver which is having LSODA cause some issues: https://discourse.julialang.org/t/differentialequations-pkg-wont-be-added/3194/22 |
For the tag, I am OK if it can help you. |
Cool thanks. Do you want me to tag or do you want to do it? |
Please do it, I have never done it. Thank you. |
The METADATA PR is in. JuliaLang/METADATA.jl#8847 Note that I will likely have another PR come in by the end of the week. It will be a small PR to the common interface which will just modify the type that things are saved to. That will be the last change for DifferentialEquations.jl ecosystem version 2.0, and so things will go stable again (I just wanted all of the changes in before the JuliaCon workshop!) |
This updates the common interface to the new specs for DiffEqBase.jl's v0.15.0. It is incompatible with previous versions.