Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update common interface #19

Merged
merged 6 commits into from
Apr 14, 2017
Merged

update common interface #19

merged 6 commits into from
Apr 14, 2017

Conversation

ChrisRackauckas
Copy link
Collaborator

This updates the common interface to the new specs for DiffEqBase.jl's v0.15.0. It is incompatible with previous versions.

@ChrisRackauckas
Copy link
Collaborator Author

I'm not sure what that load path stuff was in the tests, but that was required to be removed for tests to pass, and definitely would be required on CI.

@coveralls
Copy link

coveralls commented Apr 14, 2017

Coverage Status

Changes Unknown when pulling a85fa99 on update_ into ** on master**.

@codecov-io
Copy link

codecov-io commented Apr 14, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@50586e1). Click here to learn what that means.
The diff coverage is 91.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   87.04%           
=========================================
  Files             ?        4           
  Lines             ?      193           
  Branches          ?        0           
=========================================
  Hits              ?      168           
  Misses            ?       25           
  Partials          ?        0
Impacted Files Coverage Δ
src/common.jl 89.42% <91.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50586e1...a85fa99. Read the comment docs.

@ChrisRackauckas
Copy link
Collaborator Author

Cool. Tests pass. Would you be fine with a release after merging? I think there may be a nonlocality bug in the package resolver which is having LSODA cause some issues:

https://discourse.julialang.org/t/differentialequations-pkg-wont-be-added/3194/22

@rveltz rveltz merged commit ec00d7c into master Apr 14, 2017
@rveltz
Copy link
Owner

rveltz commented Apr 14, 2017

For the tag, I am OK if it can help you.

@ChrisRackauckas
Copy link
Collaborator Author

Cool thanks. Do you want me to tag or do you want to do it?

@ChrisRackauckas ChrisRackauckas deleted the update_ branch April 14, 2017 05:48
@rveltz
Copy link
Owner

rveltz commented Apr 14, 2017

Please do it, I have never done it.

Thank you.

@ChrisRackauckas
Copy link
Collaborator Author

The METADATA PR is in. JuliaLang/METADATA.jl#8847

Note that I will likely have another PR come in by the end of the week. It will be a small PR to the common interface which will just modify the type that things are saved to. That will be the last change for DifferentialEquations.jl ecosystem version 2.0, and so things will go stable again (I just wanted all of the changes in before the JuliaCon workshop!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants