Rebarified #2

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

nisbus commented Feb 17, 2013

Hi,

This is a minor change, basically just rebarifying erlog so it can be used as a rebar dependency.

Added rebar.config, rebar and erlog.app.src for enabling others to use erlog as a rebar dependency.
Changed the Makefile to use rebar.

Removed erlog_scan.erl and added it to .gitignore
Added rebar.config and erlog.app.src for enabling others to use erlog as a rebar dependency.
Changed the Makefile to use rebar
Owner

rvirding commented Feb 17, 2013

I will pull this later. It is good you attacked Makefile, the old one was pretty bad. I would like to make it so it uses rebar if it can find rebar, else uses erlc. The lfe Makefile does this but there is probably a better way to do it.

nisbus commented Feb 17, 2013

I think the convention is to include rebar with the repo (I'm not so sure I
like that myself) so it is a part of the branch there so it will always
find it.

On Sun, Feb 17, 2013 at 4:07 PM, Robert Virding notifications@github.comwrote:

I will pull this later. It is good you attacked Makefile, the old one was
pretty bad. I would like to make it so it uses rebar if it can find rebar,
else uses erlc. The lfe Makefile does this but there is probably a better
way to do it.


Reply to this email directly or view it on GitHubhttps://github.com/rvirding/erlog/pull/2#issuecomment-13688104.

Owner

rvirding commented Apr 24, 2014

Looking back over old stuff and saw this. The reason why I never pulled it was because it didn't have the option of using either rebar or normal make if there was no rebar. I don't see rebar as the answer. :-)

Contributor

zkessin commented May 29, 2014

My branch has a makefile that handles both cases, so maybe we should just close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment