New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color shell banner #116

Merged
merged 4 commits into from Mar 5, 2016

Conversation

Projects
None yet
4 participants
@oubiwann
Contributor

oubiwann commented Mar 10, 2015

Building upon the other branch for supporting a new shell banner, this one adds color :-)

@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Sep 21, 2015

Contributor

Here's what the color shell banner looks like :-)

screen shot 2015-09-20 at 9 45 45pm

Contributor

oubiwann commented Sep 21, 2015

Here's what the color shell banner looks like :-)

screen shot 2015-09-20 at 9 45 45pm

@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Sep 21, 2015

Contributor

Note that if you want to merge this branch, the non-coloured ASCII branch needs to be merged first (this one depends upon that one). See PR #102 ...

Contributor

oubiwann commented Sep 21, 2015

Note that if you want to merge this branch, the non-coloured ASCII branch needs to be merged first (this one depends upon that one). See PR #102 ...

@yurrriq

This comment has been minimized.

Show comment
Hide comment
@yurrriq

yurrriq Dec 28, 2015

Contributor

👍

Contributor

yurrriq commented Dec 28, 2015

👍

@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Mar 4, 2016

Contributor

@rvirding Any chance of getting this banner into LFE 1.0? :-)

Contributor

oubiwann commented Mar 4, 2016

@rvirding Any chance of getting this banner into LFE 1.0? :-)

@unbalancedparentheses

This comment has been minimized.

Show comment
Hide comment
@unbalancedparentheses

unbalancedparentheses Mar 4, 2016

Isn't a little way too big? It might be better to use when you ask for the version of lfe

Isn't a little way too big? It might be better to use when you ask for the version of lfe

@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Mar 4, 2016

Contributor

That's what I would have thought at first. The idea came from Julia's banner which I thought was a bit large at first. Then, after using it for a while, I realized I was having the same positive associations I used to have when signing on to the DEC Alpha UNIX machines in the early 90s as well as the MUDs and BBSs :-) Then I was hooked, and I wanted the same great feeling when starting up LFE :-)

Here's a Julia screenshot:
julia

Note the similarity in size ...

Contributor

oubiwann commented Mar 4, 2016

That's what I would have thought at first. The idea came from Julia's banner which I thought was a bit large at first. Then, after using it for a while, I realized I was having the same positive associations I used to have when signing on to the DEC Alpha UNIX machines in the early 90s as well as the MUDs and BBSs :-) Then I was hooked, and I wanted the same great feeling when starting up LFE :-)

Here's a Julia screenshot:
julia

Note the similarity in size ...

@rvirding

This comment has been minimized.

Show comment
Hide comment
@rvirding

rvirding Mar 4, 2016

Owner

Julia's is a bit smaller. :-) What if we cut out the steam from the mug? It's not in the "official" mug or sticker.

Owner

rvirding commented Mar 4, 2016

Julia's is a bit smaller. :-) What if we cut out the steam from the mug? It's not in the "official" mug or sticker.

@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Mar 4, 2016

Contributor

Hehe :-) Sure, let me give it a shot, see what we can get ...

Contributor

oubiwann commented Mar 4, 2016

Hehe :-) Sure, let me give it a shot, see what we can get ...

@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Mar 4, 2016

Contributor

Okay, I've updated the branch to squeeze as much room as possible. Here's what it looks like now:
lfe

It's only one more line than the Julia banner, but the text lines and vertical bar are the same size.

Contributor

oubiwann commented Mar 4, 2016

Okay, I've updated the branch to squeeze as much room as possible. Here's what it looks like now:
lfe

It's only one more line than the Julia banner, but the text lines and vertical bar are the same size.

@rvirding

This comment has been minimized.

Show comment
Hide comment
@rvirding

rvirding Mar 5, 2016

Owner

A big +1 here. Another feature for 1.0.

Owner

rvirding commented Mar 5, 2016

A big +1 here. Another feature for 1.0.

@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Mar 5, 2016

Contributor

Sweet!!!

Contributor

oubiwann commented Mar 5, 2016

Sweet!!!

@yurrriq

This comment has been minimized.

Show comment
Hide comment
@yurrriq

yurrriq Mar 5, 2016

Contributor

Nice!

Contributor

yurrriq commented Mar 5, 2016

Nice!

@rvirding rvirding merged commit 0a378c6 into rvirding:develop Mar 5, 2016

@rvirding

This comment has been minimized.

Show comment
Hide comment
@rvirding

rvirding Mar 5, 2016

Owner

I have pulled it and it is now coming in the next release. It looks good. One change I would like to make is to explicitly make the mug green like the logo. Now it comes out black with my default terminal.

Owner

rvirding commented Mar 5, 2016

I have pulled it and it is now coming in the next release. It looks good. One change I would like to make is to explicitly make the mug green like the logo. Now it comes out black with my default terminal.

@oubiwann oubiwann referenced this pull request Mar 5, 2016

Closed

Touch up new banner #193

@oubiwann oubiwann deleted the oubiwann:color-shell-banner branch Oct 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment