updated rails express patches #1119

Closed
wants to merge 10 commits into
from

Conversation

Projects
None yet
3 participants
@skaes
Contributor

skaes commented Sep 19, 2012

I spent some time on getting my patches up to date.

Can you please merge?

@mpapis mpapis closed this in c97e36d Sep 19, 2012

@mpapis

This comment has been minimized.

Show comment Hide comment
@mpapis

mpapis Sep 19, 2012

Member

currently merged on master, should this changes also be updated in stable? or it can wait for next stable (about a week).

Member

mpapis commented Sep 19, 2012

currently merged on master, should this changes also be updated in stable? or it can wait for next stable (about a week).

@skaes

This comment has been minimized.

Show comment Hide comment
@skaes

skaes Sep 19, 2012

Contributor

It can wait. Indeed it's quite possible I might push some more changes after getting feedback from our internal development team.

Contributor

skaes commented Sep 19, 2012

It can wait. Indeed it's quite possible I might push some more changes after getting feedback from our internal development team.

@ddd

This comment has been minimized.

Show comment Hide comment
@ddd

ddd Sep 20, 2012

Contributor

What I don't understand is what does Rails Express have to do with RVM? Why is RVM merging patches to support any one specific project other than itself?

Contributor

ddd commented Sep 20, 2012

What I don't understand is what does Rails Express have to do with RVM? Why is RVM merging patches to support any one specific project other than itself?

@mpapis

This comment has been minimized.

Show comment Hide comment
@mpapis

mpapis Sep 20, 2012

Member

RVM 1.x does not have support for external locations of patches/patchsets, this will be added in RVM 2.

This patches are merged to RVM to simplify using them.

Member

mpapis commented Sep 20, 2012

RVM 1.x does not have support for external locations of patches/patchsets, this will be added in RVM 2.

This patches are merged to RVM to simplify using them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment