Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

on FreeBSD, stat behaves as on OpenBSD. #1223

Merged
merged 1 commit into from

2 participants

@mat813

When upgrading on FreeBSD I got :

$ curl -L https://get.rvm.io | sudo bash -s head
Downloading RVM from wayneeseguin branch master

Upgrading the RVM installation in /usr/local/rvm/
stat: illegal option -- c
usage: stat [-FLnq] [-f format | -l | -r | -s | -x] [-t timefmt] [file ...]
stat: illegal option -- c
usage: stat [-FLnq] [-f format | -l | -r | -s | -x] [-t timefmt] [file ...]
    RVM system user group 'rvm' exists, proceeding with installation.
    Installing rvm gem in 3 gemsets ............

easy fix.

@mpapis mpapis commented on the diff
scripts/functions/installer
@@ -617,7 +617,7 @@ get_file_group()
{
case "$(uname)" in
"Darwin") stat -f "%Sg" "$1" ;;
- "OpenBSD") stat -f "%Sg" "$1" ;;
+ "OpenBSD" | "FreeBSD") stat -f "%Sg" "$1" ;;
@mpapis Owner
mpapis added a note

ok, this one is new for me, I did not know you can use spaces with quotes and alternatives here, looks more readable!

@mat813
mat813 added a note

Well, in this case, you could even do:

OpenBSD | FreeBSD)

because there's no real need for quotes.

@mat813
mat813 added a note

Could even do

*BSD)

because I think NetBSD or DragonflyBSD or the other kids on the block would work the same, but I don't have anything to test with, and they are not supposed to be supported at all :-)

@mpapis Owner
mpapis added a note

open PR with Darwin|*BSD) - I will merge it for master, so it will be available in 1.17 - there is nothing holding us back to not support all the BSD ... maybe limited support - but still always better then nothing ;)

@mat813
mat813 added a note

Ah, I pushed in the branch I had openned, but you already had merged the patch, too bad :-)
Should I open a new pull request ?

@mpapis Owner
mpapis added a note

please open a new PR - it will be targeted for RVM 1.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mpapis mpapis was assigned
@mpapis mpapis merged commit 8e9f72e into rvm:master

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 12, 2012
  1. @mat813
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  scripts/functions/installer
View
2  scripts/functions/installer
@@ -617,7 +617,7 @@ get_file_group()
{
case "$(uname)" in
"Darwin") stat -f "%Sg" "$1" ;;
- "OpenBSD") stat -f "%Sg" "$1" ;;
+ "OpenBSD" | "FreeBSD") stat -f "%Sg" "$1" ;;
@mpapis Owner
mpapis added a note

ok, this one is new for me, I did not know you can use spaces with quotes and alternatives here, looks more readable!

@mat813
mat813 added a note

Well, in this case, you could even do:

OpenBSD | FreeBSD)

because there's no real need for quotes.

@mat813
mat813 added a note

Could even do

*BSD)

because I think NetBSD or DragonflyBSD or the other kids on the block would work the same, but I don't have anything to test with, and they are not supposed to be supported at all :-)

@mpapis Owner
mpapis added a note

open PR with Darwin|*BSD) - I will merge it for master, so it will be available in 1.17 - there is nothing holding us back to not support all the BSD ... maybe limited support - but still always better then nothing ;)

@mat813
mat813 added a note

Ah, I pushed in the branch I had openned, but you already had merged the patch, too bad :-)
Should I open a new pull request ?

@mpapis Owner
mpapis added a note

please open a new PR - it will be targeted for RVM 1.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
*) stat -c "%G" "$1" ;;
esac
}
Something went wrong with that request. Please try again.