Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use the github v3 api to get the gemstone version #1338

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

copiousfreetime commented Nov 27, 2012

An attempt to fix wayneeseguin/rvm#1107

@mpapis mpapis commented on an outdated diff Nov 28, 2012

scripts/selector
@@ -197,12 +197,8 @@ __rvm_select()
rvm_ruby_package_name="${rvm_ruby_interpreter}-${rvm_ruby_version}"
rvm_ruby_url="${rvm_ruby_url:-"$maglev_url/${rvm_ruby_package_file}.${rvm_archive_extension}"}"
rvm_gemstone_version=$(
- version_tag_commit=$(
- command curl -s http://github.com/api/v2/yaml/repos/show/MagLev/maglev/tags |
- awk '/MagLev-'${rvm_ruby_version}':/ {print $2 }'
- )
- command curl -s https://raw.github.com/MagLev/maglev/$version_tag_commit/version.txt |
- GREP_OPTIONS="" \grep ^GEMSTONE | cut -f2 -d-
+ command curl -s https://raw.github.com/MagLev/maglev/MagLev-${rvm_ruby_version}/version.txt |
+ GREP_OPTIONS=""\grep ^GEMSTONE | cut -f2 -d-
@mpapis

mpapis Nov 28, 2012

Owner

the space had to be removed by accident, I have tested this fix with a space and it works fine.

@mpapis

mpapis Nov 28, 2012

Owner

could you please add the space back - this fails without it

Contributor

copiousfreetime commented Nov 28, 2012

One space added!

Member

richo commented Nov 28, 2012

I'm going to rebase the commits together, aside from that thanks!

Member

richo commented Nov 28, 2012

Merged in 75be67a

@richo richo closed this Nov 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment