runable requirements #1431

Merged
merged 19 commits into from Jan 19, 2013

Projects

None yet

3 participants

@mpapis mpapis was assigned Jan 9, 2013
@richo
Member
richo commented Jan 9, 2013

This should probably be named after the package manager it backs onto, and not the platform it runs on.

ie, requirements_apt is called by requirements_ubuntu, the latter only knowing about package names and not the actual managment.

@mpapis
Member
mpapis commented Jan 9, 2013

like scripts/functions/requirements/apt or just requirements_ubuntu to call requirements_apt ?

@richo
Member
richo commented Jan 9, 2013

For now requirements_ubuntu essentially wrapping requirements_apt seems pretty reasonable, it'll just make it easier to flesh this out later without having to play "find the reference" and churn a lot of code.

While the debian/ubuntu case is pretty clear cut, I was mainly thinking for the case like requirements_osx which first needs to work out which package manager you're using, then call it with the right package names.

@mpapis
Member
mpapis commented Jan 9, 2013

for debian / ubuntu I was thinking about using just symbolic links - and then it would make sense to rename the method to requirements_apt ...

as for osx - that's really hard one, I guess it will need some extra logic to detect homebrew/macports and fallback to something reasonable, maybe SMF - I do not want to force anybody but if they did not picked one tool already ...

@richo
Member
richo commented Jan 9, 2013

Debian and Ubuntu share apt as a package manager- but they don't share package names (at least in a lot of cases. Maybe the ones we need are in the overlap, but I'm pretty sure not).

Yeah, OSX doesn't have to happen right now but it'd be good to start on the right foot.

@mpapis
Member
mpapis commented Jan 9, 2013

I do not remember any complains from debian users ... maybe they start complaining after we automate the process.

@jrgifford
Member

What's just as bad is that between Ubuntu versions, the package names change. So I don't recommend combining ubuntu and debian. other than that, this looks good. i'll pull it down and test later today.

@mpapis mpapis merged commit cfd737d into master Jan 19, 2013
@mpapis mpapis deleted the feature/requirements_exec branch Jan 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment