autoconf/automake support on Solaris #2187

Merged
merged 13 commits into from Sep 3, 2013

Projects

None yet

2 participants

@Ch00k
Member
Ch00k commented Sep 3, 2013

Also fixes JRuby installation on Solaris 10

@mpapis mpapis commented on an outdated diff Sep 3, 2013
binscripts/rvm-installer
@@ -49,13 +49,19 @@ else
log "Trying to install GNU version of tar, might require sudo password"
if (( UID ))
then
- pkginfo -q CSWpkgutil || sudo pkgadd -a $rvm_path/config/solaris/noask -d http://get.opencsw.org/now CSWpkgutil
+ if \which sudo >/dev/null 2>&1
+ then sudo_10=sudo
+ elif \which /opt/csw/bin/sudo >/dev/null 2>&1
+ then sudo_10=/opt/csw/bin/sudo
+ else fail "sudo is required but not found"
@mpapis
mpapis Sep 3, 2013 Member

how about at least a link where to get it or instructions how to get it?

@mpapis mpapis and 1 other commented on an outdated diff Sep 3, 2013
scripts/functions/pkg
@@ -112,8 +112,8 @@ install_package()
if
[[ "${rvm_skip_autoreconf_flag:-0}" == 0 ]] &&
- __rvm_which autoreconf >/dev/null 2>&1 &&
- __rvm_which libtoolize >/dev/null 2>&1 &&
+ __rvm_which __rvm_autoreconf >/dev/null 2>&1 &&
@mpapis
mpapis Sep 3, 2013 Member

this makes no sense in current form - remove the two checks for __rvm_autoreconf and __rvm_libtoolize

@Ch00k
Ch00k Sep 3, 2013 Member

Why do you think it does not make sense? __rvm_autoreconf and __rvm_libtoolize can still call an inexisting binary under the hood.

@mpapis
mpapis Sep 3, 2013 Member

yes they can be but then __rvm_which __rvm_autoreconf does check only if the wrapper exist - and we should either move the check there or just skip it at all

@Ch00k
Member
Ch00k commented Sep 3, 2013

I made the necessary changes

@mpapis mpapis merged commit 5ad2605 into rvm:master Sep 3, 2013
@mpapis
Member
mpapis commented Sep 3, 2013

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment