New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few typos in upgrade-notes.txt #2238

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@codebykat
Contributor

codebykat commented Oct 1, 2013

Just a couple quick things I noticed when I upgraded :)

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Oct 1, 2013

Member

can you please move the changed points to the end - we use diff and display the incoming changes to the user - without moving to the end only the changed lines would appear without proper context or ending.

Member

mpapis commented Oct 1, 2013

can you please move the changed points to the end - we use diff and display the incoming changes to the user - without moving to the end only the changed lines would appear without proper context or ending.

@codebykat

This comment has been minimized.

Show comment
Hide comment
@codebykat

codebykat Oct 2, 2013

Contributor

Oh, I see. Okay, reordered. 😃

Contributor

codebykat commented Oct 2, 2013

Oh, I see. Okay, reordered. 😃

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Oct 2, 2013

Member

https://travis-ci.org/wayneeseguin/rvm/builds/12032683#L249 - still not good, can you move the initially changed lines to the end of the file?

Member

mpapis commented Oct 2, 2013

https://travis-ci.org/wayneeseguin/rvm/builds/12032683#L249 - still not good, can you move the initially changed lines to the end of the file?

@mpapis mpapis closed this in 46194ee Oct 2, 2013

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Oct 2, 2013

Member

I had to play a bit to make it display properly in the diff, hopefully it will not conflict with older version, we need to find better format for newer versions so the notes can be improved without creating conflicts, possibly separate files - but then it's work for RVM 2.

Member

mpapis commented Oct 2, 2013

I had to play a bit to make it display properly in the diff, hopefully it will not conflict with older version, we need to find better format for newer versions so the notes can be improved without creating conflicts, possibly separate files - but then it's work for RVM 2.

@codebykat

This comment has been minimized.

Show comment
Hide comment
@codebykat

codebykat Oct 2, 2013

Contributor

OK cool! Sorry, that ended up being a lot of trouble for a couple lousy typos. 😅

Contributor

codebykat commented Oct 2, 2013

OK cool! Sorry, that ended up being a lot of trouble for a couple lousy typos. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment