Remove early check for LLVM with TruffleRuby #4427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(TruffleRuby also looks up in Homebrew and MacPorts directories on macOS).
So this logic is redundant because per-platform checks for installing LLVM are already in RVM and TruffleRuby itself checks if
clang
&opt
are available when it needs to compile C extensions.It's also needlessly restrictive for Homebrew and MacPorts (forcing the LLVM executables to be in
PATH
), so it needs to be removed.cc @havenwood