Remove early check for LLVM with TruffleRuby #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TruffleRuby already checks later and looks up more paths to find the LLVM executables clang and opt. * See oracle/truffleruby#1386.
eregon
force-pushed
the
truffleruby-remove-early-llvm-check
branch
from
c6f9156
to
e6e61f6
Compare
havenwood
approved these changes
Jul 10, 2018
|
@havenwood Thanks for merging so quickly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(TruffleRuby also looks up in Homebrew and MacPorts directories on macOS).
So this logic is redundant because per-platform checks for installing LLVM are already in RVM and TruffleRuby itself checks if
clang&optare available when it needs to compile C extensions.It's also needlessly restrictive for Homebrew and MacPorts (forcing the LLVM executables to be in
PATH), so it needs to be removed.cc @havenwood