Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown command wrappers #5027

Merged
merged 3 commits into from Jan 8, 2021

Conversation

wintersolutions
Copy link
Contributor

Rubygems plugin loading was changed in
rubygems >= 3.2 this leads to gem-wrappers
not being loaded in a new context.

This fix registers the gem-wrappers plugin before its
being used.

See rubygems/rubygems#3108

Fixes #5020.

Changes proposed in this pull request:

  • Run gem pristine gem-wrappers --only-plugins before running gem wrappers regenerate to avoid plugin loading issues with rubygems >= 3.2

Make sure that your pull request includes entry in the CHANGELOG.

Rubygems plugin loading was changed in
rubygems >= 3.2 this leads to gem-wrappers
not being loaded in a new context.

This fix registers the gem-wrappers plugin before its
being used.

See rubygems/rubygems#3108
@pkuczynski pkuczynski requested a review from mpapis January 6, 2021 22:25
@pedrofurtado
Copy link
Member

pedrofurtado commented Jan 7, 2021

@pkuczynski @mpapis Happy to see this merged asap 🎉 🎉

Thanks @wintersolutions ! 🤝

c/c: @WillRadi

@pedrofurtado
Copy link
Member

pedrofurtado commented Jan 8, 2021

@pkuczynski @mpapis I've tested locally the branch, and it worked like a charm 🎉 Ruby 3 installed correctly 🤝

@pkuczynski pkuczynski added the bug label Jan 8, 2021
@pkuczynski pkuczynski added this to the rvm-1.29.12 milestone Jan 8, 2021
Copy link
Member

@pkuczynski pkuczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pkuczynski pkuczynski merged commit 3c034ad into rvm:master Jan 8, 2021
@pedrofurtado
Copy link
Member

pedrofurtado commented Jan 8, 2021

@pkuczynski When you have time, could you release a minor version of rvm for us? 🤝 We are waiting a official release with this hotfix to upgrade rvm and install ruby3 in our production environments 👍 🏆

Ps: Thanks again @wintersolutions ! 🎖️

@wintersolutions
Copy link
Contributor Author

Thanks!

@DanyWallace
Copy link

I tried multiple clean installs of debian10, and I'm getting this after this change:

dan@cibo:~$ \curl -sSL https://get.rvm.io | bash -s -- --ignore-dotfiles
Turning on ignore dotfiles mode.
Downloading https://github.com/rvm/rvm/archive/master.tar.gz
/home/dan/.rvm/src/rvm/scripts/functions/installer: line 1420: syntax error near unexpected token `('
/home/dan/.rvm/src/rvm/scripts/functions/installer: line 1420: `            __rvm_with "${__gem_home##*/}" (gem pristine gem-wrappers --only-plugins || true) && gem wrappers regenerate'
Installing RVM to /home/dan/.rvm/
/home/dan/.rvm/src/rvm/scripts/functions/installer: line 26: update_gemsets_install_rvm: command not found
/home/dan/.rvm/src/rvm/scripts/functions/installer: line 26: configure_autolibs: command not found
/home/dan/.rvm/src/rvm/scripts/functions/installer: line 26: update_yaml_if_needed: command not found
/home/dan/.rvm/src/rvm/scripts/functions/installer: line 26: cleanup_tmp_files: command not found
/home/dan/.rvm/src/rvm/scripts/functions/installer: line 26: record_installation_time: command not found
/home/dan/.rvm/src/rvm/scripts/functions/installer: line 26: print_install_footer: command not found
/home/dan/.rvm/src/rvm/scripts/functions/installer: line 26: display_notes: command not found

@pedrofurtado
Copy link
Member

@teeigeryuh Take a look on this PR that I've created. Thanks for feedback!: #5029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when generating default wrappers in 'rvm install 3.0.0'
4 participants