Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for this great image
Summary
This PR resolves #9 adding typescript support through ts-protoc-gen
Changes
node:${NODE_VERSION}-alpine${ALPINE_VERSION}
) rather thanalpine${ALPINE_VERSION}
ts-protoc-gen
npm global packagets-protoc-gen
to protoc pluginsNotes for Reviewers
I'm aware that changing the final image is not the best but I've chosen to do that because in unfortunately
ts-protoc-gen
is a node script instead of a runnable binary, therefore node must be installed.I've tried to install node through
apk
but the available versions are very limited (the latest version available is nodejs-12.18.4).I've tried the installation directly with the binary through
wget
but it didn't work because of a broblem withmusl
library.That being said, in my opinion the best option in order to have a stable image is to use the official, alpine-based, node image.
If you think there's a better solution, I'm very open to suggestions and ideas
Release Notes
Despite the final image is changed, this pull request should not contains any breaking change, however I've been able to test only the ts, js and go generation because my current stack contains only this three languages