Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript support #64

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Add typescript support #64

merged 1 commit into from
Dec 14, 2020

Conversation

FedeBev
Copy link
Contributor

@FedeBev FedeBev commented Nov 16, 2020

Hi there, thanks for this great image

Summary

This PR resolves #9 adding typescript support through ts-protoc-gen

Changes

  • runtime image is now node-alpine based (node:${NODE_VERSION}-alpine${ALPINE_VERSION}) rather than alpine${ALPINE_VERSION}
  • add ts-protoc-gen npm global package
  • add ts-protoc-gen to protoc plugins

Notes for Reviewers

I'm aware that changing the final image is not the best but I've chosen to do that because in unfortunately ts-protoc-gen is a node script instead of a runnable binary, therefore node must be installed.
I've tried to install node through apk but the available versions are very limited (the latest version available is nodejs-12.18.4).
I've tried the installation directly with the binary through wget but it didn't work because of a broblem with musl library.
That being said, in my opinion the best option in order to have a stable image is to use the official, alpine-based, node image.
If you think there's a better solution, I'm very open to suggestions and ideas

Release Notes

Despite the final image is changed, this pull request should not contains any breaking change, however I've been able to test only the ts, js and go generation because my current stack contains only this three languages

@rvolosatovs rvolosatovs self-assigned this Dec 14, 2020
@rvolosatovs rvolosatovs added this to the November 2020 milestone Dec 14, 2020
@rvolosatovs rvolosatovs merged commit ef1e573 into rvolosatovs:master Dec 14, 2020
@rvolosatovs
Copy link
Owner

Thanks!

@rvolosatovs rvolosatovs mentioned this pull request Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Typescript
2 participants