Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 946989 - [Messages][Drafts] Duplicate threadless drafts get saved #3

Closed
wants to merge 1 commit into from

Conversation

evhan55
Copy link

@evhan55 evhan55 commented Dec 6, 2013

  • drafts.js
    • changed add() to delete existing, threadless drafts if the new draft being added matches draft.id
  • thread_ui.js
    • ensures that the thread in the thread list is updated if a draft gets updated
  • drafts_test.js
    • tests that threadless drafts are properly replaced
  • thread_ui_test.js
    • tests that thread update is called upon draft saving

stored = null;
return true;
}
}).bind(this));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no bind here, just use the thisArg for some:

array.some(function() {

}, this);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks, changing now

@evhan55 evhan55 closed this Dec 10, 2013
@evhan55
Copy link
Author

evhan55 commented Dec 10, 2013

Moving this commit over to a v1.3-drafts branch on evhan55

rwaldron pushed a commit that referenced this pull request Feb 18, 2014
Update SIM bookmark customization to include sample mcc mnc US SIM customization, r=@yurenju
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants