extract JSCS config into .jscsrc #632

Closed
boneskull opened this Issue Feb 23, 2015 · 2 comments

Projects

None yet

2 participants

@boneskull
Contributor

JetBrains IDEs, and probably other text editors, support inline JSCS linting. However, as long as the JSCS config is in the Gruntfile, they don't know what rules to use.

Cut the JSCS config from Gruntfile.js and paste it into a new .jscsrc.

@rwaldron
Owner

Go for it!

@boneskull boneskull added a commit to boneskull/johnny-five that referenced this issue Feb 24, 2015
@boneskull boneskull extract jscs config into .jscsrc; resolves #632 214464c
@boneskull boneskull added a commit to boneskull/johnny-five that referenced this issue Feb 24, 2015
@boneskull boneskull extract jscs config into .jscsrc; resolves #632
- created `jscs` npm script target; `npm run-script jscs`
- removed JSCS config from `Gruntfile.js`; config now lives in `.jscsrc`
- added JSCS as devDependency
- added `util/` to paths covered by JSCS
- fixed JSCS errors in `util/xbee.js`
  - a couple formatting problems
  - you can't `return` a `process.exit()` call
  - fixed what appeared to be a logic error when no port name specified; would exit too early
  - the above three issues were reported by JSCS
c57da18
@boneskull
Contributor

see PR #633

@rwaldron rwaldron pushed a commit that closed this issue Feb 25, 2015
@boneskull boneskull extract jscs config into .jscsrc; resolves #632
- removed JSCS config from `Gruntfile.js`; config now lives in `.jscsrc`
- added `util/` to paths covered by JSCS
- fixed JSCS errors in `util/xbee.js`
  - a couple formatting problems
  - you can't `return` a `process.exit()` call
  - fixed what appeared to be a logic error when no port name specified; would exit too early
  - the above three issues were reported by JSCS
4bf24c0
@rwaldron rwaldron closed this in 4bf24c0 Feb 25, 2015
@donaldaverill donaldaverill added a commit to donaldaverill/johnny-five that referenced this issue Feb 27, 2015
@donaldaverill donaldaverill Merge branch 'master' of https://github.com/rwaldron/johnny-five
# By Rick Waldron (4) and Christopher Hiller (2)
# Via Rick Waldron
* 'master' of https://github.com/rwaldron/johnny-five:
  Examples: cleanups and removals
  Accelerometer: MMA7361 diagram fixups
  Emit an actual Error instance object
  v0.8.44
  extract jscs config into .jscsrc; resolves #632
  add npm-debug.log to .gitignore

Conflicts:
	.gitignore
1613f19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment