Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Piezo doesn't work #92

Closed
chrusttt opened this Issue Nov 23, 2012 · 9 comments

Comments

Projects
None yet
6 participants

when trying to turn on Piezo ex, throws exception,
Piezo is undefined.

I have the same issue.

Owner

rwaldron commented Jan 8, 2013

Sorry—I could've sworn I had responded to this!!

The Piezo constructor is intentionally disabled, pending a major amount of refactoring—which I need help with. If either one of you wants to take a stab at fleshing out the Piezo functionality, I'd be forever thankful :D

Contributor

DebugXYZ commented May 30, 2013

hacked around with this @ jsconf (emphasis on the hacking) with @pfiller https://gist.github.com/pfiller/5680471

just mostly getting familiar with johnny-five (and hardware in general) but would like to take a proper stab at it and put in a pull request.

Owner

rwaldron commented Jun 3, 2013

@deshawnbw sounds good—I just landed a patch from @bengillies, so check that out too

I noticed the missing example/documentation for Piezo to. Seeing that this issue is not closed, am I right to assume no proper stab is delivered by either @deshawnbw, @pfiller or @bengillies?

I would like to contribute back by picking up this issue. I have the following plan

  1. Make Piezo work
  2. Make it work idiomatically
  3. Write an example
  4. Write documentation

Without further notice I will start working on it.

Owner

rwaldron commented Oct 25, 2013

Sounds good, but be warned: Piezo needs delayMicroseconds for making tones and there Firmata does not support process blocking operations like delay or delayMicroseconds, so you'll need to figure out if it's possible to do in JS.

Thanks for the heads up. So I will try to solve to problem. I will post my progress in this issue.

Owner

rwaldron commented Oct 25, 2013

Awesome :)

Contributor

julianduque commented Nov 19, 2013

Added a PR with the delayMicroseconds approach using nanotimer

@rwaldron rwaldron closed this in #256 Nov 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment