New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser-serialport dependency for NW.js support via Firmata #1028

Merged
merged 2 commits into from Feb 4, 2016

Conversation

Projects
None yet
3 participants
@djipco
Contributor

djipco commented Feb 3, 2016

I submitted a very similar and related pull request for the Firmata module (firmata/firmata.js#108). If both PRs are merged in, NW.js v0.13 and Johnny-Five would work together right out of the box. The huge gain is that it would no longer be necessary to custom-compile node-serialport for NW.js (which is prohibitively complicated for beginners).

With the small changes I'm suggesting in this PR and the one for Firmata, I was able to successfully use Arduino + browser-serialport + Firmata + Johnny-Five + NW.js. This is an amazingly powerful combination for physical computing and robotics.

@djipco

This comment has been minimized.

Show comment
Hide comment
@djipco

djipco Feb 4, 2016

Contributor

According to AppVeyor, my tiny change is not compatible with version 0.12 but is with version 0.10. The Thermometer test cases are not happy. Does anybody know if it's actually related to this pull request or if it's something else entirely? I tried looking into it but I'm not sure what the problem is.

Contributor

djipco commented Feb 4, 2016

According to AppVeyor, my tiny change is not compatible with version 0.12 but is with version 0.10. The Thermometer test cases are not happy. Does anybody know if it's actually related to this pull request or if it's something else entirely? I tried looking into it but I'm not sure what the problem is.

@rwaldron

This comment has been minimized.

Show comment
Hide comment
@rwaldron

rwaldron Feb 4, 2016

Owner

According to AppVeyor, my tiny change is not compatible with version 0.12 but is with version 0.10. The Thermometer test cases are not happy. Does anybody know if it's actually related to this pull request or if it's something else entirely? I tried looking into it but I'm not sure what the problem is.

The failure is unrelated, I just re-ran this to get it green (because I knew it would pass on re-run)

Owner

rwaldron commented Feb 4, 2016

According to AppVeyor, my tiny change is not compatible with version 0.12 but is with version 0.10. The Thermometer test cases are not happy. Does anybody know if it's actually related to this pull request or if it's something else entirely? I tried looking into it but I'm not sure what the problem is.

The failure is unrelated, I just re-ran this to get it green (because I knew it would pass on re-run)

rwaldron added a commit that referenced this pull request Feb 4, 2016

Merge pull request #1028 from cotejp/master
Add browser-serialport dependency for NW.js support via Firmata

@rwaldron rwaldron merged commit 41562ce into rwaldron:master Feb 4, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment