fix for #35 #36

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@tammo0

still looking for a way to prove it with a test...
Problem is that sequence is really over, but not the last videoclip...

@cadecairos cadecairos and 1 other commented on an outdated diff May 16, 2012
popcorn.sequence.js
@@ -325,7 +325,17 @@
play: function() {
- this.playlist[ this.active ].play();
+ if (((this.queue.length-1) == this.active) &&
+ (this.inOuts["ofVideos"][this.active]["out"] >= Math.round(this.queue[this.active].currentTime)))
+ {
+
+ return this;
@cadecairos
cadecairos May 16, 2012

maybe we should cycle back to the first clip and play from there. That's how html5 video works.

@tammo0
tammo0 May 16, 2012

just replace "return this;" with "this.jumpTo(0);" - works fine for me

@tammo0 tammo0 added a commit to tammo0/popcorn.sequence that referenced this pull request May 16, 2012
@tammo0 tammo0 test for issue #35 and its fix at issue #36 11cef4c
@cadecairos cadecairos added a commit to cadecairos/sequence that referenced this pull request May 17, 2012
@tammo0 tammo0 test for issue #35 and its fix at issue #36 3e9f472
@cadecairos cadecairos added a commit to cadecairos/sequence that referenced this pull request May 17, 2012
@cadecairos cadecairos style fixes for play() update and tests, detabbed the files. [#36 and #… 49fa19e
@cadecairos cadecairos closed this May 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment