Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Mar 15, 2009
  1. @danlynn @emk

    Corrected comments to reflect actual behavior.

    danlynn authored emk committed
Commits on Feb 9, 2009
  1. @emk

    filtered_column_code_macro: Word-wrap comment

    emk authored
    I'm trying to keep comments below 80 columns in new code, so I don't
    have to resize my Emacs window.
  2. @emk

    filtered_column_code_macro: Default to 'rake test'

    emk authored
    In general, Rails applications seem to reserve a bare rake command for
    running 'rake test'.  So I'm going ahead and making that the default
    here, for better or for worse.
  3. @danlynn

    Add default codemacro stylesheets for theme usage.

    danlynn authored
    Updated main README with instructions on how to 
    link to these stylesheets.  A codemacro Rakefile 
    was added with tasks to test the plugin and 
    generate a new default_coderay.css stylesheet.  
    The codemacro plugin now wraps all code listings 
    in a <div> enabling horizontal scrolling and 
    dynamic width.
Commits on Dec 22, 2008
  1. @emk

    Unbundle tzinfo gem

    emk authored
    Sadly, unpacking tzinfo into vendor gems breaks Rails' time zone
    support and gives the following error when trying to access
    admin/settings:
    
      uninitialized constant TZInfo::Timezone::TimezoneProxy
    
    So we're going to instruct the user to install this gem using 'sudo
    rake gems:install' for now.
Commits on Dec 20, 2008
  1. @emk

    Update to emk-safe_erb 0.1.2

    emk authored
    This fixes script/generate and the standard Rails error page.
Commits on Dec 19, 2008
  1. @emk

    Attempt to escape strings in FlickrMacro

    emk authored
    This plugin had absolutely no HTML escaping.  I've attempted to fix
    this, but since the API key has expired, this code has not been tested.
Commits on Dec 17, 2008
  1. @emk

    Add highly-experimental safe_erb support

    emk authored
    This should help prevent unescaped text from being displayed in ERB
    templates, which should in turn help prevent XSS attacks.  This code is
    based on the safe_erb plugin, written by Shinya Kasatani and updated by
    Matthew Bass, with a whole bunch of changes to better support Mephisto
    and Rails 2.2.
    
    v2:
      Freeze emk-safe_erb 0.1.1, with MySQL support
Commits on Dec 16, 2008
  1. @emk

    Unpack tzinfo into vendor/gems

    emk authored
    This is an experimental change: Can we just go ahead and bundle tzinfo?
    This should certainly simplify installation for our users.  But it also
    makes it (slightly) harder to upgrade tzinfo when the timezones change.
    
    Let me know if this patch causes trouble.
Commits on Dec 12, 2008
  1. @emk

    Security: Replace white_list with Rails 2.2 sanitizer

    emk authored
    The Rails 2.2 santizer is an enhanced version of Rick's original
    white_list plugin, so let's upgrade and get the latest fixes.
    
    Note that Mephisto had separate rules for sanitizing comments and
    non-comments in Atom feeds.  This difference was introduced in commit
    88df87e.  Unfortunately, I'm not able
    to track down any information on the problem being fixed here.  Since we
    already add half of the tags in question to the whitelist, I've decided
    to just treat all sanitized Atom feed content the same.  Please let me
    know if this breaks anything.
Commits on Dec 9, 2008
  1. @emk

    Strip leading and trailing newlines from <macro:code>

    emk authored
    This allows us to write things like:
    
    <macro:code>
    x = y + 2
    </macro:code>
    
    ...and not get gratuitous empty lines at either end.
Commits on Dec 8, 2008
  1. @emk

    Silence default_error_messages warning

    emk authored
    Note that this is a local modification to an upstream plugin, but it's
    pretty minor, and it's OK to discard it when upgrading attachment_fu.
  2. @emk

    Replace embedded copy of coderay with up-to-date gem version

    emk authored
    Here's one more library hiding inside vendor/plugins that we can just
    treat as a normal gem.  Note that this patch doesn't fix any of our
    underlying <macro:code> problems.
    
    This does get us support for quite a few more languages, and it allows
    us to replace our custom JavaScript support with the new JavaScript
    support in the upstream library.
  3. @emk

    Clean up code_macro test suites slightly & fix HTML escaping

    emk authored
    The "css" option to the <macro:code> form was never actually
    implemented, and the associated unit tests are failing.  So I removed
    the test cases and the useless option.
    
    I also added some test cases to check that "<" characters in code get
    escaped properly, and fixed the code to make the tests pass.
    
    In general, <macro:code> has a number of fairly serious problems, and
    the unit tests aren't testing what they think they're testing, largely
    thanks to some error-recovery code that masks underlying exceptions.
Commits on Dec 7, 2008
  1. @emk

    Remove a_gems plugin

    emk authored
    This plugin provided "gems:*" tasks, which are now available in
    Rails 2.2.  It was also responsible for loading vendor/rubypants-0.2.0,
    which is an old, customized gem that we can't put into the regular gems
    directory without some repackaging work.  So we just handle that case
    manually for now.
  2. @emk

    Change test-spec contexts into regular unit tests

    emk authored
    This completely removes our depency on the test-spec library, which is
    no longer maintained.
Commits on Dec 6, 2008
  1. @emk

    Upgrade to latest mocha

    emk authored
  2. @emk

    Upgrade to will_paginate 2.2.2

    emk authored
  3. @emk

    Move machinist to vendor/gems

    emk authored
  4. @emk

    Move liquid to vendor/gems

    emk authored
  5. @emk

    Start using config.gem to manage gems

    emk authored
    These gems can all be moved easily without breaking our unit tests.  Use
    'rake gems', etc., to list and manage gems declared with config.gem.
    
    We update a couple of gems here, most notable rubyzip.  We don't update
    to the newest version of RedCloth, because Mephisto seemed to want a
    specific version before, and the newest version includes a native
    extension that we don't want to deal with right now.
Commits on Dec 5, 2008
  1. @isaackearse
  2. @emk

    Remove labeled_form_helper, switch to standard one

    emk authored
    All these features are available in core.  We won't know if this patch
    is good until we actually get the website up, though.
  3. @emk

    Remove simply_helpful plugin

    emk authored
    All the features of the simply_helpful plugin were either merged into
    core Rails, or were deprecated.  So let's just get rid of it and clean
    up any damage as we go.
    
    Removing this fixes quite a few unit test failures.
  4. @emk

    Upgrade to latest release of attachment_fu

    emk authored
    Updated to commit 42a37fab15c6d1dacc6043ee40b25de12b63ac04 from
    repository git://github.com/technoweenie/attachment_fu.git .  Note that
    this version of attachment_fu is actually deprecated in favor of the
    forthcoming rewrite.
    
    We need to add some explicit attr_accessible declarations to match
    Mephisto's old behavior.
Commits on Dec 4, 2008
  1. @emk

    Upgrade to latest acts_as_versioned

    emk authored
    This eliminates some API conflicts with Rails 2.2 and gets more of the
    tests passing.  This is version c310d2805ed243fd7587afcc5cec1bbbb9198947
    from git://github.com/technoweenie/acts_as_versioned.git .
  2. @emk

    Update for miscellenous API changes in Rails 2.2.2

    emk authored
    The tests will now load, but they have a massive number of failures.
  3. @emk

    Upgrade to latest development version of engines

    emk authored
    This is commit 4cb49974cc62e6e89c15b03d08bab3ba07f7213a from the
    git://github.com/lazyatom/engines.git repository.  The released
    version of engines doesn't seem to support Rails 2.2 at the
    moment.
    
    Note that the unit tests still won't run.
Commits on Dec 3, 2008
  1. @emk

    Convert specs from model_stubbing to machinist (all tests green)

    emk authored
    With this patch, our tests now run at 100%!
    
    Our remaining spec failures all involved model_stubbing, an old library
    by Rick.  According to Rick, he's no longer maintaining model_stubbing,
    and he recommends that we use machinist to generate test data instead.
    
    This patch rips out model_stubbing, and replaces it with a combination
    of machinist and faker.  In most cases, the new code is quite a bit
    shorter, simpler and easier to understand.
    
    A few minor things worth noting:
      - Several rspec blocks have been combined or nested.
      - Unnecessary setup code has been removed.
      - Two of the three copies of the code in site_spec.rb have been
        deleted.
      - An extra test case has been added for membership_spec.rb, to
        better document some interesting behavior I discovered while
        debugging.
    
    The machinist plugin is version 17985ba55aff6420caadb70ef698dd93aef5a26b
    from http://github.com/notahat/machinist/tree/master.
Commits on Dec 2, 2008
  1. @emk

    Fix TRUNCATE TABLE errors in in-tree model_stubbing

    emk authored
    As discovered by Aubrey Holland, model_stubbing relies on the
    non-portable TRUNCATE TABLE command:
    
      http://groups.google.com/group/MephistoBlog/msg/7da91b7410271ff2
    
    Applying Aubrey's fix allows 'rake spec' to run against SQLite3.  Note
    that there are still a good number of spec failures which will need to
    be addressed.
    
    It's a little bit dodgy to patch the in-tree copy of model_stubbing,
    but doing so will suffice for now.
Commits on Dec 1, 2008
  1. @emk

    Freeze test-spec gem so unit tests work

    emk authored
    The Mephisto unit tests rely on 'test/spec', which is provided by the
    test-spec gem.  Since the rest of our test support libraries are already
    frozen (as vendor/plugins/rspec and vendor/plugins/rspec_on_rails), it
    won't hurt to freeze one more gem and make the unit tests runnable out
    of the box.
    
    Note that 'rake' and 'rake spec' both result in numerous errors and test
    failures.  I've spoken to another recent Mephisto contributor on #mephisto,
    and they confirmed that quite a few tests are currently broken.
Commits on Mar 29, 2008
  1. @isaackearse
Commits on Mar 4, 2008
  1. @technoweenie
Commits on Feb 20, 2008
  1. @svenfuchs
Commits on Feb 6, 2008
  1. @svenfuchs
Something went wrong with that request. Please try again.