New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement random number opcodes [0098, 0099, 0208, 0209]. #439

Merged
merged 2 commits into from May 6, 2018

Conversation

Projects
None yet
3 participants
@christoph-heiss
Copy link
Contributor

christoph-heiss commented May 3, 2018

Hi!

Not much to say, really. Implemented using C++ std::{random_device,mt19937}.

I originally wrote this about a month ago or two, and thought I would just PR this now - I do have finals at the moment and not really a lot of time. And before this code rots ..

Greets!

christoph-heiss added some commits Feb 16, 2018

Implement opcodes 0098, 0099, 0208 and 0209.
These opcodes are relevant for generating random values.

dracc added a commit to dracc/openrw that referenced this pull request May 3, 2018

Implemented various opcodes.
Update to C++11 random taken care of by @christoph-heiss in rwengine#439 .

@dracc dracc referenced this pull request May 3, 2018

Closed

Implemented various opcodes. #435

@dracc

This comment has been minimized.

Copy link
Contributor

dracc commented May 3, 2018

Looks bloody awesome to me!

dracc added a commit to dracc/openrw that referenced this pull request May 4, 2018

Cleanup
Opcode decimal names removed.
std::rand() usage reverted in favour of rwengine#439
@darkf

This comment has been minimized.

Copy link
Collaborator

darkf commented May 6, 2018

LGTM, thanks.

@darkf darkf merged commit 512f1d2 into rwengine:master May 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@husho husho referenced this pull request May 7, 2018

Closed

New opcodes #363

@christoph-heiss christoph-heiss deleted the christoph-heiss:new-opcodes branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment