New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready] Fixed script objects falling through the ground #450

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
2 participants
@husho
Copy link
Contributor

husho commented May 12, 2018

This fixes issue when during the game intro few objects fall through the ground.

  • 0107 opcode
  • 0392 opcode​

Issues to fix:

  • Lamposts act weirdly now, seems like they only fall down after 2nd hit
  • Hydrants don't longer break

@husho husho changed the title Fixes script objects falling through the ground Fixed script objects falling through the ground May 12, 2018

@ghost

This comment has been minimized.

Copy link

ghost commented May 13, 2018

its cause u have created a switch action, when the car hits the lamposts he trigger to true, and when he hits again, if true the lampost fall, make a test with this, the lampost will fall down with the first hit damage
image

but i dont know if this is the right method to make this works, maybe u need set the physcs to true when he detect if the impact can break the lampost

@ghost

This comment has been minimized.

Copy link

ghost commented May 13, 2018

After the fix, some hydrants dont break when u hit with the car(high speed) but when u give small hits near the hydrant he breaks, its normal ?

@husho

This comment has been minimized.

Copy link
Contributor

husho commented May 13, 2018

I'll test

@husho

This comment has been minimized.

Copy link
Contributor

husho commented May 13, 2018

What you described happens in master branch, in my branch hydrants don't even break

@@ -308,7 +308,8 @@ void ObjectRenderer::renderVehicle(VehicleObject* vehicle,
void ObjectRenderer::renderPickup(PickupObject* pickup, RenderList& outList) {
if (!pickup->isEnabled()) return;

glm::mat4 modelMatrix = glm::translate(glm::mat4(1.0f), pickup->getPosition());
glm::mat4 modelMatrix =
glm::translate(glm::mat4(1.0f), pickup->getPosition());

This comment has been minimized.

@danhedron

danhedron May 13, 2018

Member

Looks like there's just formatting changes in this file

This comment has been minimized.

@husho

husho May 13, 2018

Contributor

getVisible was placed with isVisible

RW_UNUSED(args);
object->setStatic(!arg2);

This comment has been minimized.

@danhedron

danhedron May 13, 2018

Member

The description of this opcode seems to be that it turns collision detection on and off, not change static status.

This comment has been minimized.

@husho

husho May 13, 2018

Contributor

You right. Will fix.

@husho husho changed the title Fixed script objects falling through the ground [WIP] Fixed script objects falling through the ground May 14, 2018

@husho husho changed the title [WIP] Fixed script objects falling through the ground [Ready] Fixed script objects falling through the ground May 15, 2018

@husho husho referenced this pull request May 22, 2018

Merged

[Ready] Garages #480

10 of 27 tasks complete

@danhedron danhedron merged commit de81319 into rwengine:master May 22, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@husho husho deleted the husho:objphy branch May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment