New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CPack to create archives on appveyor #503

Merged
merged 6 commits into from Jun 9, 2018

Conversation

Projects
None yet
4 participants
@madebr
Copy link
Collaborator

madebr commented Jun 4, 2018

I'm using TXZ because that one has the highest compression ratio. 7z would also be a great choice.

$ du -b OpenRW-13946234.* | sort
1286216	OpenRW-13946234.tar.xz
1286970	OpenRW-13946234.7z
1905566	OpenRW-13946234.tar.bz2
2430744	OpenRW-13946234.tar.gz
2432541	OpenRW-13946234.zip
2469706	OpenRW-13946234.sh
3539451	OpenRW-13946234.tar.Z
@danhedron
Copy link
Member

danhedron left a comment

lgtm

@@ -159,3 +159,10 @@ target_include_directories(rwengine
)

openrw_target_apply_options(TARGET rwengine)

if(INSTALL_LIBS)
install(TARGETS rwengine

This comment has been minimized.

@danhedron

danhedron Jun 4, 2018

Member

Is there a reason we'd want to install the static library?

This comment has been minimized.

@madebr

madebr Jun 4, 2018

Collaborator

Support for third person total conversions 🤣 .

Shared libraries should be installed.
We can switch the test to BUILD_SHARED_LIBS.

@madebr madebr force-pushed the madebr:cpack branch 2 times, most recently from 6fbd6d5 to f8c4fb7 Jun 4, 2018

@ShFil119

This comment has been minimized.

Copy link
Member

ShFil119 commented Jun 7, 2018

lgtm, should I close #466?

@darkf

This comment has been minimized.

Copy link
Collaborator

darkf commented Jun 8, 2018

Needs a rebase.

@madebr madebr force-pushed the madebr:cpack branch from 609ab66 to 92cb999 Jun 8, 2018

@madebr

This comment has been minimized.

Copy link
Collaborator

madebr commented Jun 8, 2018

rebased and tested artifact on appveyor using wine

@darkf

This comment has been minimized.

Copy link
Collaborator

darkf commented Jun 9, 2018

Thanks.

@darkf darkf merged commit e17f17c into rwengine:master Jun 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@madebr madebr deleted the madebr:cpack branch Jun 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment