Fix relative target of manpage links. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] we noticed that mocassin could not be built reproducibly. This led me to discover that the mocassinOutput(1), mocassinPlot(1) and mocassinWarm(1) manpages were linking to the absolute location for the mocassin(1) manpage, so they would not work when distributed: For example mocassinOutput.1.gz linked to, on my machine: /home/lamby/temp/cdt.20210215121553.ZpEolGOptg.repro.mocassin/build-a/mocassin-2.02.73.1/debian/tmp/usr/share/man/man1/mocassin.1.gz Patch attached that uses relative URLs instead. This change would also make the build reproducible. I originally filed this in Debian as #982851 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/982851
|
Thanks for providing this patch! I have updated the debian package with the new version to close that bug also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort we noticed that mocassin could not be built reproducibly.
This led me to discover that the
mocassinOutput(1),mocassinPlot(1)andmocassinWarm(1)manpages were linking to the absolute location for themocassin(1)manpage, so they would not work when distributed:For example
mocassinOutput.1.gzlinked to, on my machine:Patch attached that uses relative URLs instead. This change would also make the build reproducible. I originally filed this in Debian as #982851.