-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow launching on a custom Tokio runtime #1097
Conversation
Ideally we could have a method that took only |
Ah, I originally assumed this was just to be able to customize the runtime, not the ability to launch on a runtime that may already exist and does other things. That's certainly a different situation. I've opted to accept a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to merge after these minor adjustments so that #1079 is combined with these changes.
I think both functions will change further, but this is a great starting point to play with the functionality.
This change necessitates an identical change to `.launch()`.
Merged as 70ca157. |
Currently only on a Tokio runtime for reasons described in #1068. In the future, it would naturally be ideal to allow launching on any runtime; such a change would necessitate larger code changes to provide for a common API.
Resolves #1068.