Sqlx 0.7 update

[auipga]

Changelog of sqlx
TL;DR:

• MSSQL feature gone -> 6638570
• offline feature gone -> 076343d, cafcbbf
• another dereference needed for mut db: Connection<Logs> (🙏🏻reddit) -> 5e15bc7
• opt is consuming self, changed somewhere between 0.6.3 and 0.7.0-alpha.1 -> acf3b73

Fixes: "use two different sqlx versions?" when using shuttle.rs

• All tests are passing

---

I'm new to Rust. This is my first contribution to the Rust community. Please tell me, if you would have done this better. I'm willing to learn.

[SergioBenitez]

This appears to be doing something similar to what #2597 does. Is there a reason to prefer one or the other? Does #2597 actually subsume the changes in this PR?

[auipga]

Oh man, same work done twice 🤦🏻‍♂️ At least I learned something by doing it myself.

The only differences to #2597 that I spotted are options for tls:

• f96d120#diff-b07af3edcc9e0cbef28b433c304b22197ae60b092d0b4496c3be9cbb9715cc57R40-R42
• 6909a2c#diff-2704e80751ab4993f7c6bc12f6d7ab9a69abeddc182fa5cd47867a582f8ade15R256-R284

To your questions:

• both PRs will do the job. Though mine has no reformats.
• yes, plus the added tls fields (I'd think this shouldn't be included in an regular update)

[SergioBenitez]

I was about to merge (a version of) this when I noticed spurious failures caused by a change I made to the sqlx example:

 #[post("/", data = "<post>")]
-async fn create(mut db: Connection<Db>, post: Json<Post>) -> Result<Created<Json<Post>>> {
-    // There is no support for `RETURNING`.
-    sqlx::query!("INSERT INTO posts (title, text) VALUES (?, ?)", post.title, post.text)
-        .execute(&mut *db)
-        .await?;
+async fn create(mut db: Connection<Db>, mut post: Json<Post>) -> Result<Created<Json<Post>>> {
+    let query = sqlx::query! {
+        "INSERT INTO posts (title, text) VALUES (?, ?) RETURNING id",
+        post.title, post.text
+    };

+    post.id = Some(query.fetch_one(&mut **db).await?.id);
     Ok(Created::new("/").body(post))
 }

This is something I had been wanting the example to do for some time but we lacked an updated version of sqlite, which we now have. Unfortunately, this causes spurious test failures because an insertion is at times not reflected:

DELETE /sqlx:
   >> Matched: (destroy) DELETE /sqlx
   >> Outcome: Success
POST /sqlx application/json:
   >> Matched: (create) POST /sqlx
   >> Outcome: Success
GET /sqlx:
   >> Matched: (list) GET /sqlx
   >> Outcome: Success
POST /sqlx application/json:
   >> Matched: (create) POST /sqlx
   >> Outcome: Success
GET /sqlx:
   >> Matched: (list) GET /sqlx
   >> Outcome: Success
thread 'tests::test_sqlx' panicked at databases/src/tests.rs:38:9:
assertion `left == right` failed
  left: 1
 right: 2

The sqlx version of the example is the only one that fails even though I've updated the other examples to use RETURNING as well. We can't merge this change until we understand why this is happening and get a fix in wherever appropriate. (P.S: I considered whether the defaults for sqlite connections had changed in sqlx, e.g, whether WAL is still default, but it seems they have not.)

I've pushed the was-ready-to-merge sqlx-0.7-update for your investigation.

[SergioBenitez]

Looks like the issue I outline above is launchbadge/sqlx#2543. I'm rather surprised that this seemingly very serious issue has been completely ignored for over two months, or longer (launchbadge/sqlx#1648).

[SergioBenitez]

Worked around the issue. Merged in aa7805a. Thank you!